Skip to content

refact: merge example and test example apps - #2225

Merged
alduzy merged 20 commits into
mainfrom
@alduzy/merge-example-apps
Jul 9, 2024
Merged

alduzy merged 20 commits into
mainfrom
@alduzy/merge-example-apps

Conversation

@alduzy

@alduzy alduzy commented Jul 2, 2024 •

Copy link
Copy Markdown
Contributor

Description

This PR intents to merge together the example and test-example apps resulting in less configuration files.
TestsExample and FabricTestExample apps are removed so there's only Example, FabricExample and TVOSExample app to take care of.

it is more convenient to use Example and FabricExample apps to run tests as there is less configuration files to take care of, less building and less metro restarting. Simply replace the returned component in apps/App.tsx with the selected test and you're ready for testing. For example replace <Example/> with <Test.Test42/>.

Changes

  • removed TestsExample and FabricTestExample apps
  • allowed for source change in apps/App.tsx file to switch between example and tests

Test code and steps to reproduce

Run the Example or FabricExample app and change source in apps/App.tsx file.

Checklist

@alduzy
alduzy requested review from kkafar, maciekstosio and tboba July 2, 2024 12:33
Comment thread apps/TestApp.tsx Resolved
Comment thread guides/CONTRIBUTING.md Resolved
@alduzy
alduzy requested review from WoLewicki and maciekstosio July 2, 2024 15:31
Comment thread apps/App.tsx Resolved
@alduzy
alduzy requested a review from maciekstosio July 8, 2024 13:53
@alduzy
alduzy force-pushed the @alduzy/merge-example-apps branch 2 times, most recently from f75abdf to 86d469f Compare July 8, 2024 14:16

@maciekstosio maciekstosio left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 🎉

Co-authored-by: maciekstosio <maciekstosio@icloud.com>
@alduzy
alduzy force-pushed the @alduzy/merge-example-apps branch from 5dc1318 to c5cd87a Compare July 9, 2024 09:11

@kkafar kkafar left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, this looks nice. Thank you!

Just few remarks & we'll be good to go.

Comment thread guides/CONTRIBUTING.md Resolved
Comment thread apps/src/tests/index.ts Resolved

@kkafar kkafar left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, I've answered my concerns myself 😄 Looks good 💪🏻

Co-authored-by: Kacper Kafara <kacper.kafara@swmansion.com>
@alduzy
alduzy merged commit 151c1c7 into main Jul 9, 2024
@alduzy
alduzy deleted the @alduzy/merge-example-apps branch July 9, 2024 12:42
ja1ns pushed a commit to WiseOwlTech/react-native-screens that referenced this pull request Oct 9, 2024
## Description

This PR intents to merge together the example and test-example apps
resulting in less configuration files.
TestsExample and FabricTestExample apps are removed so there's only
Example, FabricExample and TVOSExample app to take care of.

it is more convenient to use Example and FabricExample apps to run tests
as there is less configuration files to take care of, less building and
less metro restarting. Simply replace the returned component in
`apps/App.tsx` with the selected test and you're ready for testing. For
example replace `<Example/>` with `<Test.Test42/>`.

## Changes

- removed TestsExample and FabricTestExample apps
- allowed for source change in `apps/App.tsx` file to switch between
example and tests

<!--

## Screenshots / GIFs

Here you can add screenshots / GIFs documenting your change.

You can add before / after section if you're changing some behavior.

### Before

### After

-->

## Test code and steps to reproduce

Run the Example or FabricExample app and change source in `apps/App.tsx`
file.

## Checklist

- [x] Updated documentation: <!-- For adding new props to native-stack
-->
- [x]
https://github.com/software-mansion/react-native-screens/blob/main/guides/CONTRIBUTING.md
- [x] Ensured that CI passes

---------

Co-authored-by: maciekstosio <maciekstosio@icloud.com>
Co-authored-by: Kacper Kafara <kacper.kafara@swmansion.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants