Skip to content

refact: remove unnecessary workflow step - #2226

Merged
alduzy merged 1 commit into
mainfrom
@alduzy/skip-unnecessary-worklfow-step
Jul 2, 2024
Merged

alduzy merged 1 commit into
mainfrom
@alduzy/skip-unnecessary-worklfow-step

Conversation

@alduzy

@alduzy alduzy commented Jul 2, 2024 •

Copy link
Copy Markdown
Contributor

Description

I noticed there's an unnecessary step in the worklfow both for iOS and android e2e tests.
The step is supposed to install any dependencies inside examples/app but there's no package.json file.
This PR removes the step.

Changes

  • removed workflow step

Test code and steps to reproduce

Checklist

  • Ensured that CI passes

@alduzy
alduzy marked this pull request as ready for review July 2, 2024 14:21
@alduzy
alduzy requested review from kkafar and maciekstosio July 2, 2024 14:21

@kkafar kkafar left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a good catch. Thanks.

@alduzy
alduzy merged commit e5a6220 into main Jul 2, 2024
@alduzy
alduzy deleted the @alduzy/skip-unnecessary-worklfow-step branch July 2, 2024 15:05
ja1ns pushed a commit to WiseOwlTech/react-native-screens that referenced this pull request Oct 9, 2024
## Description

I noticed there's an unnecessary step in the worklfow both for iOS and
android e2e tests.
The step is supposed to install any dependencies inside `examples/app`
but there's no `package.json` file.
This PR removes the step.

## Changes

- removed workflow step

<!--

## Screenshots / GIFs

Here you can add screenshots / GIFs documenting your change.

You can add before / after section if you're changing some behavior.

### Before

### After

-->

## Test code and steps to reproduce

<!--
Please include code that can be used to test this change and short
description how this example should work.
This snippet should be as minimal as possible and ready to be pasted
into editor (don't exclude exports or remove "not important" parts of
reproduction example)
-->

## Checklist

- [x] Ensured that CI passes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants