Repository navigation
chore: remove unused code in podspec - #2241
Merged
Merged
Conversation
maciekstosio
approved these changes
Jul 9, 2024
tboba
approved these changes
Jul 9, 2024
tboba
left a comment
Contributor
There was a problem hiding this comment.
That's good! Have you tested if project with RN 0.71 installed works correctly on Paper/Fabric with this change?
Member
Author
|
Nope |
Contributor
|
Let me check that |
Contributor
|
Everything seems to work fine there! I think we can proceed. |
kkafar
approved these changes
Jul 12, 2024
1 task
This was referenced Aug 23, 2024
This was referenced Aug 30, 2024
ja1ns
pushed a commit
to WiseOwlTech/react-native-screens
that referenced
this pull request
Oct 9, 2024
## Description Since we support RN from 0.71, and `install_modules_dependencies` is already available there, we can remove the unused code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Since we support RN from 0.71, and
install_modules_dependenciesis already available there, we can remove the unused code.