Skip to content

chore: remove unused code in podspec - #2241

Merged
tboba merged 1 commit into
mainfrom
@wolewicki/remove-unused-code
Jul 12, 2024
Merged

tboba merged 1 commit into
mainfrom
@wolewicki/remove-unused-code

Conversation

@WoLewicki

Copy link
Copy Markdown
Member

Description

Since we support RN from 0.71, and install_modules_dependencies is already available there, we can remove the unused code.

@tboba tboba left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's good! Have you tested if project with RN 0.71 installed works correctly on Paper/Fabric with this change?

@WoLewicki

Copy link
Copy Markdown
Member Author

Nope

@tboba

tboba commented Jul 9, 2024

Copy link
Copy Markdown
Contributor

Let me check that

@tboba

tboba commented Jul 9, 2024

Copy link
Copy Markdown
Contributor

Everything seems to work fine there! I think we can proceed.

@kkafar kkafar left a comment •

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, the code changes do look ok. If we're good down to 0.71 (or even 0.72, as that will be the last version we support with release of 0.75) then we're good here.

Thanks

@tboba
tboba merged commit 6219db1 into main Jul 12, 2024
@tboba
tboba deleted the @wolewicki/remove-unused-code branch July 12, 2024 08:51
ja1ns pushed a commit to WiseOwlTech/react-native-screens that referenced this pull request Oct 9, 2024
## Description

Since we support RN from 0.71, and `install_modules_dependencies` is
already available there, we can remove the unused code.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants