Skip to content

refact: unified prettier config across repository - #2250

Merged
alduzy merged 7 commits into
mainfrom
@alduzy/prettier-config-across-apps
Jul 18, 2024
Merged

alduzy merged 7 commits into
mainfrom
@alduzy/prettier-config-across-apps

Conversation

@alduzy

@alduzy alduzy commented Jul 17, 2024 •

Copy link
Copy Markdown
Contributor

Description

This PR intents to unify prettier config across example apps. Inititally I wanted to copy the configuration but It's more convenient to just use the one from the root (by not overriding it).

Changes

  • removed per project .prettierrc files
  • fixed eslint export syntax in Example
  • formatted affected files

Checklist

  • Ensured that CI passes

@alduzy
alduzy requested review from kkafar, maciekstosio and tboba July 17, 2024 13:53

@kkafar kkafar left a comment •

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the changes.

I'm just leaving a link to prettier docs with description of config file resolution algorithm, so that it is clear why removing .prettierrc.js files from applications works.

One note, I personally like trailingComma: 'all' option, as it makes adding new parameter / call / element less awkward. Won't insist here.

@alduzy

alduzy commented Jul 18, 2024

Copy link
Copy Markdown
Contributor Author

@kkafar Here you go 😉

@kkafar kkafar left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@alduzy
alduzy merged commit c70f23b into main Jul 18, 2024
@alduzy
alduzy deleted the @alduzy/prettier-config-across-apps branch July 18, 2024 10:07
ja1ns pushed a commit to WiseOwlTech/react-native-screens that referenced this pull request Oct 9, 2024
)

## Description

This PR intents to unify prettier config across example apps. Inititally
I wanted to copy the configuration but It's more convenient to just use
the one from the root (by not overriding it).

## Changes

- removed per project `.prettierrc` files
- fixed eslint export syntax in Example
- formatted affected files

<!--

## Screenshots / GIFs

Here you can add screenshots / GIFs documenting your change.

You can add before / after section if you're changing some behavior.

### Before

### After

-->

<!--
## Test code and steps to reproduce

Please include code that can be used to test this change and short
description how this example should work.
This snippet should be as minimal as possible and ready to be pasted
into editor (don't exclude exports or remove "not important" parts of
reproduction example)
-->

## Checklist

- [x] Ensured that CI passes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants