Skip to content

fix: added missing icon and launch screen to fabric example - #2268

Merged
alduzy merged 4 commits into
mainfrom
@alduzy/fabric-example-icons-and-launch
Jul 30, 2024
Merged

alduzy merged 4 commits into
mainfrom
@alduzy/fabric-example-icons-and-launch

Conversation

@alduzy

@alduzy alduzy commented Jul 30, 2024 •

Copy link
Copy Markdown
Contributor

Description

This PR adds missing icon and launch screen to FabricExample app.
After copying the icons from paper example i noticed there are icons for iPad and the example itself supports iPad platform. Thus I decided to add the iPad support to fabric example as well.

Changes

  • added iOS icons and launch screen
  • added iPad support
  • added android icons and launch screen

Screenshots / GIFs

Before

Screenshot 2024-07-30 at 11 13 17
Screenshot 2024-07-30 at 11 15 08

After

Screenshot 2024-07-30 at 13 20 29
Screenshot 2024-07-30 at 12 54 53

Checklist

  • Ensured that CI passes

@alduzy
alduzy requested review from WoLewicki, kkafar and tboba July 30, 2024 09:16
@tboba

tboba commented Jul 30, 2024

Copy link
Copy Markdown
Contributor

Great change! Just leaving one suggestion here.
In Reanimated, Example app and FabricExample app have different app icons. This allows the developer to visually distinguish app with old and new arch. Can we do something similar there? I would go for having an outline version of logo in FabricExample app, something like in our docs (maybe with gradient kept?) - you can find the logo here.

image

For reference, I'm also leaving links for reanimated logos:
https://github.com/software-mansion/react-native-reanimated/blob/main/apps/paper-example/android/app/src/main/ic_launcher-playstore.png
https://github.com/software-mansion/react-native-reanimated/blob/main/apps/fabric-example/android/app/src/main/ic_launcher-playstore.png

@kkafar

kkafar commented Jul 30, 2024

Copy link
Copy Markdown
Member

I've also thought of that @tboba, but I don't think we have such graphic ready. Unless @alduzy can rustle one up in half an hour, otherwise I'm for merging this PR as is.

@alduzy

alduzy commented Jul 30, 2024

Copy link
Copy Markdown
Contributor Author

I've replaced the icon on fabric as @tboba suggested 😉

@kkafar

kkafar commented Jul 30, 2024

Copy link
Copy Markdown
Member

Murarz tynkarz akrobata

Nice

@kkafar kkafar left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A load of new kilobytes for our repository (that hurts me), but fine :D 🟢

@alduzy
alduzy merged commit 325f27e into main Jul 30, 2024
@alduzy
alduzy deleted the @alduzy/fabric-example-icons-and-launch branch July 30, 2024 14:36
ja1ns pushed a commit to WiseOwlTech/react-native-screens that referenced this pull request Oct 9, 2024
…-mansion#2268)

## Description

This PR adds missing icon and launch screen to `FabricExample` app.
After copying the icons from paper example i noticed there are icons for
iPad and the example itself supports iPad platform. Thus I decided to
add the iPad support to fabric example as well.

## Changes

- added iOS icons and launch screen
- added iPad support
- added android icons and launch screen

## Screenshots / GIFs

### Before
![Screenshot 2024-07-30 at 11 13
17](https://github.com/user-attachments/assets/791dd46d-7e4a-4e54-bcfa-20893255dfe3)
![Screenshot 2024-07-30 at 11 15
08](https://github.com/user-attachments/assets/98c9d114-270c-4ccf-b876-b7215ee70a43)

### After
![Screenshot 2024-07-30 at 13 20
29](https://github.com/user-attachments/assets/c1c29c73-fd5b-4f33-820d-424fea6fdf15)
![Screenshot 2024-07-30 at 12 54
53](https://github.com/user-attachments/assets/1d033532-4d5b-465d-9289-19da50674013)


## Checklist

- [x] Ensured that CI passes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants