Repository navigation
fix(iOS): fix quick modal presentation sequence where foreign modal is being dismissed - #2671
Merged
Merged
Conversation
kkafar
commented
Feb 6, 2025
kkafar
left a comment
Member
Author
There was a problem hiding this comment.
Note
We need to automate these and regression test everything that can be tested 😅
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes #2668
See the #2668 for issue description.
Making long story short: The issue involves cases when we have two modals
A, b, whereAis owned andbis foreign, and wedismiss
band present another owned modalBin single transaction or in separate transactions but pulled quickly enough so that previous transitions (caused by previous transaction) are not finished yet.Currently, because of
bbeing dismissed by its host view controller, we would wrongfully dismiss the controller underneath (A). Now the code takes possibility ofbbeing in dismissal into account.Changes
We now check whether the potentially foreign modal is being dismissed - if so, we schedule our updates to run after dismissal transition completes.
Test code and steps to reproduce
Tested for regressions:
Modalscreen in Example PRThis issue is quite similar to #1299 but concerns foreign modal not owned one and mechanism are a bit different, therefore I've added
Test2668.Checklist