Skip to content

fix: remove setting opacity with self keyword inside RNSVGNode - #2774

Merged
jakex7 merged 3 commits into
software-mansion:mainfrom
kacperzolkiewski:fixPrepareForRecycle
Sep 30, 2025
Merged

jakex7 merged 3 commits into
software-mansion:mainfrom
kacperzolkiewski:fixPrepareForRecycle

Conversation

@kacperzolkiewski

@kacperzolkiewski kacperzolkiewski commented Sep 17, 2025 •

Copy link
Copy Markdown
Collaborator

Summary

Remove setting variables inside RNSVGNode with self. and use underscore _ instead.

Test Plan

  • Example app -> TouchEvents
  • Create G with some Rect inside it and set opacity for G to 0 (Content inside G should be invisible)

Compatibility

OS Implemented
iOS ✅
MacOS ❌
Android ❌
Web ❌

Checklist

  • I have tested this on a device and a simulator

@kacperzolkiewski kacperzolkiewski changed the title fix: remove setting variables with self inside RNSVGNode fix: remove setting opacity with self keyword inside RNSVGNode Sep 17, 2025
@kacperzolkiewski
kacperzolkiewski marked this pull request as ready for review September 17, 2025 10:33
@jakex7
jakex7 merged commit 2b4a348 into software-mansion:main Sep 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants