Repository navigation
fix: allow children on web Defs - #3056
Merged
Merged
Conversation
Native Defs is PropsWithChildren. The web class extended bare WebShape, so moduleSuffixes [".web", ""] rejected <Defs> children.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Web
Defsdid not declare children on its props generic, so TypeScript consumers that resolve.webfirst (e.g.moduleSuffixes: [".web", ""]) rejected<Defs>{children}</Defs>.This showed up in Expensify App: Expensify/App#99495
Native
Defs(src/elements/Defs.tsx) isComponent<React.PropsWithChildren>. Sibling web classes (G,Mask,Symbol,ClipPath, etc.) already passWebShape<BaseProps & XProps>. WebDefswas the only one extending bareWebShape.Implementation:
export class Defs extends WebShape<PropsWithChildren<BaseProps>>insrc/elements.web.ts. Types-only; no runtime change.Impact: web TypeScript declarations only.
Test Plan
Type-only; no device or simulator test.
With
moduleSuffixes: [".web", ""],tscshould accept:What's required for testing (prerequisites)?
TypeScript consumer that resolves
react-native-svgvia.websuffixes.What are the steps to reproduce (after prerequisites)?
<Defs>with children against the web declaration.tscno longer errors thatchildrenis not a valid prop.Compatibility
Types-only web.
Checklist
README.md__tests__folder