ci: fix cache issue#51
Open
nbelenkov wants to merge 2 commits into
Open
Conversation
Signed-off-by: Nikita Belenkov <nikita.belenkov@anza.xyz>
Contributor
Author
|
cc @joncinque @yihau |
joncinque
approved these changes
Jul 14, 2026
Comment on lines
+170
to
+172
| env: | ||
| PACKAGE_PATH: ${{ inputs.package-path }} | ||
| run: cargo semver-checks --manifest-path "${PACKAGE_PATH}/Cargo.toml" |
Contributor
There was a problem hiding this comment.
For my own information, what exactly does the env variable provide in a case like this? The variable is already quoted, so it should end up exactly the same, no?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two hardening changes to the Rust and JS publish workflows, following pinocchio#434.
Drop caching in the publish flow
The gated
publishjobs restored caches that unprotected jobs in the same flow also wrote to. Keys aren't scoped by environment andrestore-keysmatch by prefix, so an unprotected job could seed a cache the privileged publish job later restores and runs under the publish token.Added a
cacheinput tosetup-ubuntu(defaults totrue, so CI is unchanged) that gates the pnpm, Solana, and cargo caches, and setcache: falseon the publish setup steps.Pass inputs via env vars
Free-form inputs (
version,level,tag, etc.) were interpolated straight intorun:scripts, allowing shell injection. They're now bound to stepenv:and used as quoted shell variables.