Skip to content

Switch to stable Rust - #38

Merged
raphael-theriault-swi merged 2 commits into
mainfrom
NH-147522
Sep 3, 2026
Merged

Switch to stable Rust#38
raphael-theriault-swi merged 2 commits into
mainfrom
NH-147522

Conversation

@raphael-theriault-swi

Copy link
Copy Markdown
Contributor

This will produce slightly bigger binaries since we no longer compile the standard library, but it should make the build process more stable while keeping the size difference negligible.

@raphael-theriault-swi
raphael-theriault-swi requested a review from a team as a code owner September 2, 2026 21:07
Copilot AI lite review requested due to automatic review settings September 2, 2026 21:07
@raphael-theriault-swi
raphael-theriault-swi requested a review from a team as a code owner September 2, 2026 21:07

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Repository documentation (README) still states nightly is required, which will be incorrect after this toolchain switch.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

This PR updates the Rust build toolchain configuration to use the stable compiler channel and removes nightly-only Cargo configuration previously used for building the standard library.

Changes:

  • Switch rust-toolchain.toml from nightly to stable and drop the rust-src component.
  • Remove .cargo/config.toml’s [unstable] build-std configuration (nightly-only).
File summaries
File Description
rust-toolchain.toml Pins the repo to the stable Rust channel and adjusts installed components accordingly.
.cargo/config.toml Removes nightly-only build-std configuration so builds no longer depend on Cargo nightly features.
Review details
  • Files reviewed: 2/2 changed files
  • Comments generated: 1
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread rust-toolchain.toml
Co-authored-by: raphael-theriault-swi <113933910+raphael-theriault-swi@users.noreply.github.com>

@cheempz cheempz left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@raphael-theriault-swi
raphael-theriault-swi merged commit 05b4caf into main Sep 3, 2026
9 checks passed
@raphael-theriault-swi
raphael-theriault-swi deleted the NH-147522 branch September 3, 2026 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants