Repository navigation
Remove limit of 10 NTP servers being configured - #30500
Open
saiarcot895 wants to merge 1 commit into
Open
saiarcot895 wants to merge 1 commit into
saiarcot895 wants to merge 1 commit into
Conversation
The NTP daemon will use however many it wishes to use for time synchronization, and neither Chrony nor ntpd have limits on how many can be configured. Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>
saiarcot895
requested review from
dgsudharsan,
praveen-li,
qiluo-msft and
venkatmahalingam
as code owners
November 2, 2026 17:57
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
Collaborator
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
A positive schema-validation test with at least 11 distinct NTP servers is still missing, leaving the removed ten-server limit without regression coverage.
1 open issue
What changed in this PR
This PR removes the ten-server limit from SONiC’s NTP YANG model, allowing configurations with more than ten upstream NTP servers.
Changes:
- Removes
max-elements 10fromNTP_SERVER_LIST. - Simplifies the list description, removing the guidance link about excessive upstream servers.
| File | Description |
|---|---|
src/sonic-yang-models/yang-models/sonic-ntp.yang |
Removes the NTP server count restriction and updates the list description. |
Review effort: Balanced
| "Number of upstream NTP servers is discussed at | ||
| https://support.ntp.org/bin/view/Support/SelectingOffsiteNTPServers | ||
| (5.3.4. Excessive Number of Upstream Time Servers)."; | ||
| "List of all upstream servers to use."; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why I did it
The NTP daemon will use however many it wishes to use for time synchronization, and neither Chrony nor ntpd have limits on how many can be configured.
Work item tracking
How I did it
Allow configuring any number of NTP servers by removing the YANG restriction of 10 elements.
How to verify it
Which release branch to backport (provide reason below if selected)
Tracking issue/work item for backport/cherry-pick request (GitHub issue or Microsoft ADO):
Failure type:
Tested branch
Test result
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)