Skip to content

Fix bug causing build_user_filter to filter incorrectly. - #1072

Merged
RichDom2185 merged 2 commits into
source-academy:masterfrom
GabrielCWT:fix/submissions-filter
Feb 25, 2024
Merged

RichDom2185 merged 2 commits into
source-academy:masterfrom
GabrielCWT:fix/submissions-filter

Conversation

@GabrielCWT

Copy link
Copy Markdown
Contributor
  • Changed build_user_filter to use correct table. student_id in Submissions refers to the Course Reg ID, not the User ID.

student_id in Submissions refers to the Course Reg ID, not the User ID.
@coveralls

coveralls commented Feb 24, 2024 •

Copy link
Copy Markdown

Coverage Status

coverage: 94.958% (-0.03%) from 94.992%
when pulling 268b360 on GabrielCWT:fix/submissions-filter
into 11154a6 on source-academy:master.

@RichDom2185 RichDom2185 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@RichDom2185
RichDom2185 merged commit 749c544 into source-academy:master Feb 25, 2024
@GabrielCWT
GabrielCWT deleted the fix/submissions-filter branch February 25, 2024 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants