Skip to content

Implement tests for submissions_by_grader_for_index - #1088

Merged
RichDom2185 merged 15 commits into
source-academy:masterfrom
GabrielCWT:feat/assessment_filter_tests
Mar 21, 2024
Merged

Implement tests for submissions_by_grader_for_index#1088
RichDom2185 merged 15 commits into
source-academy:masterfrom
GabrielCWT:feat/assessment_filter_tests

Conversation

@GabrielCWT

@GabrielCWT GabrielCWT commented Mar 14, 2024

Copy link
Copy Markdown
Contributor
  • Improves test seed to accomodate for new test requirements
  • Implement tests for submissions_by_grader_for_index function

Closes #1071
Closes #1073

GabrielCWT added 15 commits March 12, 2024 20:36
@GabrielCWT
feat: Implement test for filter by assessment title
b38057c
@GabrielCWT
feat: Implement random submission status in test seed
9e2c748
@GabrielCWT
feat: Implement test for filter by submission status
c87261e
@GabrielCWT
feat: Implement random graded status in test seed
8b0ad56
@GabrielCWT
feat: Implement test for filter by notFullyGraded
ab6d254
@GabrielCWT
feat: Improve test seed and make tests pure
e951a55
@GabrielCWT
feat: Update seed to include second group and avenger
06753a2
@GabrielCWT
feat: Implement tests for filtering by group
e75dc5e
@GabrielCWT
feat: Implement tests for filter by group name
3278ed8
@GabrielCWT
feat: Implement tests for filter by student name
991081b
@GabrielCWT
feat: Implement tests for filter by student username
05f805e
@GabrielCWT
feat: Implement tests for filter by manually graded config
5e0e769
@GabrielCWT
refactor: Remove whitespace and move asserts to the bottom
c893611
@GabrielCWT
chore: Remove unused variables in test seed
cd76dbe
@GabrielCWT
refactor: Remove unnecessary code
fd3dd30
@coveralls

coveralls commented Mar 16, 2024

Copy link
Copy Markdown

Coverage Status

coverage: 95.31% (+0.5%) from 94.822%
when pulling fd3dd30 on GabrielCWT:feat/assessment_filter_tests
into 2f0746b on source-academy:master.

@GabrielCWT
GabrielCWT marked this pull request as ready for review March 16, 2024 11:18
@GabrielCWT
GabrielCWT requested a review from RichDom2185 March 16, 2024 11:19
@GabrielCWT GabrielCWT mentioned this pull request Mar 16, 2024
Merged
RichDom2185
RichDom2185 approved these changes Mar 21, 2024
View reviewed changes

@RichDom2185 RichDom2185 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks a lot!

@RichDom2185
RichDom2185 merged commit 8208743 into source-academy:master Mar 21, 2024
@GabrielCWT
GabrielCWT deleted the feat/assessment_filter_tests branch March 21, 2024 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@RichDom2185 RichDom2185 RichDom2185 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Improve Test Seed Implement Tests for Assessment Filtering

3 participants

@GabrielCWT @coveralls @RichDom2185