Frontend MVP for Source Academy Rook by chownces · Pull Request #1878 · source-academy/frontend

chownces · 2021-07-28T10:09:46Z

Description

Frontend MVP for Source Academy Rook

Status:

~~To get feedback on UI~~
Need to set up auth providers (Google, Github)
~~Frontend mockups not updated yet~~
~~'Paths' logic is yet to be refactored~~
~~Assessment 'Grade' has not been fully removed~~
~~To relook at course 'viewability' for admins (it is currently disabled for all when viewable == false)~~
Check that achievements are working properly

Note: To temporarily disable the create course button for deployment

Changelog (Knight --> Rook):

Added multitenant functionality
- UI for running multiple courses concurrently on our new backend
- Users can now create new courses, or enroll in multiple courses
Updated frontend routing
- There are now 3 main possible deployment configurations:
  1. Source Academy @ NUS: uses the backend
    - Playground and Sourcecast are now hidden behind the login and are no longer publicly accessible
    - The new SICPJS feature is also hidden behind the login
  2. Playground-only: does not use the backend
    - No notable changes in routing
    - The new SICPJS feature is publicly accessible
  3. Source Academy with GitHub Classroom: an extension of 1 and 2
    - Enables the GitHub Classroom functionality in either deployment
    - Publicly accessible in either deployment
Updates to setting of course configuration
- Previously, the game and achievements were disabled via environment variables in the frontend
- Now, they are persisted in the backend by course. Different courses can enable/ disable different features at the same time
New admin panel for course admins
- Course settings such as course name, user management and toggling of features can now be done in this new admin panel
- Hardcoded to allow upserts of up to 1000 users at a time
Changes to testcase types
- Not much change to the behaviour of these types on the frontend, the changes were mostly due to backend refactoring
- Previously: Public, Hidden and Private
- Now: Public, Opaque and Secret
'Grade' metric has been deprecated. Assessments will now solely use XP for grading.

Type of change

New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
This change requires a documentation update

How to test

To be tested with the new backend (source-academy/backend#775)

Checklist

I have tested this code
I have updated the documentation

…y configurations

…Assessment type

…kend. Yarn format

…pe routes toLowerCase

… were previously commented out already

…er to use postCourseConfig saga

…anguage on first render

…be hardcoded to assessement types

chownces · 2021-07-28T10:10:46Z

Accidentally merged in the previous PR ==. Reissuing it here

chownces · 2021-07-28T10:15:07Z

      title: assessmentOverview.title,
      ability:
-        assessmentOverview.category === 'Mission' || assessmentOverview.category === 'Path'
+        assessmentOverview.type === 'Missions' || assessmentOverview.type === 'Paths'


probably need the achievements team to remove this hardcode

This may need a new assessment flag: "Show in achievements?"

Will be removing this categorisation as discussed. Probably in #1886

chownces · 2021-07-28T10:15:52Z

+    if (data.length + users.length > 1000) {
+      setInvalidCsvMsg('Please limit each upload to 1000 entries!');
+      hasInvalidInput = true;
+    }


still hardcoded to 1000 per upload for now. will be relooked when the super user rights are implemented

…urse for this user

angelsl

Looks good mostly, just a few minor issues

angelsl · 2021-08-01T10:09:56Z

      title: assessmentOverview.title,
      ability:
-        assessmentOverview.category === 'Mission' || assessmentOverview.category === 'Path'
+        assessmentOverview.type === 'Missions' || assessmentOverview.type === 'Paths'


This may need a new assessment flag: "Show in achievements?"

angelsl · 2021-08-01T20:43:17Z

    : 'excluded';
+
+const courseId: () => string = () => {
+  const id = store.getState().session.courseId;


This makes me very very sad...

Ok but in all seriousness, we can merge for now but when we get the course ID in the route, it would be good to pass it in as a parameter rather than accessing a global singleton like that

angelsl · 2021-08-01T21:11:15Z

I left quite a few comments but I think the main issues are

avoid accessing the Redux store via the store global as far as possible (this should be resolved once the course ID is in the URL, future PR)
avoid hardcoding NUS and NUS-specific terms in new text (this one we can do in a future PR, it's fine)
avoid using connected components for new components, use hooks e.g. useSelector instead
also, any typos

…Selector in Welcome Page. Fix miscellaneous typos

angelsl

Thanks for all the work!

chownces added 30 commits June 12, 2021 14:11

Remove game and achievements toggle in .env

3999046

Added CourseRegistration and CourseConfiguration to session types

90a9a62

Added achievements and game toggle from store

9fa8214

Updated Application routes for Source Academy @nus and playground-onl…

4dd33a2

…y configurations

Updated Academy Assessment routes and changed Assessment category to …

03d9c36

…Assessment type

Updated academy navbar routing and included assessment types from bac…

412dc99

…kend. Yarn format

Handle conditional rendering of sourcecast and playground in navbar

c8c4655

Handle notifications filter in navbar

4d59fb2

Updated to AssessmentType instead of string

aa980a0

Update SessionState and default SessionState

a54c7cb

Fix AchievementSaga.ts compilation errors

6e1be61

Updated FETCH_AUTH in BackendSaga.ts, and made BackendSaga compilable

0c8d9ee

Refactor AchievementSaga

12f2cf4

RequestsSaga, and added /user and config update endpoints

191aebb

Commented out sublanguages related reducers and sagas

26e60f3

Yarn format

b536946

Updated AssessmentMocks to reflect new AssessmentTypes

fb7c79f

Updated UserMocks notifications to reflect new AssessmentTypes

6cfacc6

Make EditingOverviewCard compilable, and updated navbar assessment ty…

8846024

…pe routes toLowerCase

Make Profile compilable

e4e5551

Renamed AssessmentTypes to AssessmentType[]

eadd5c3

Make ProfileCard compilable

acf0fe8

Make AssessmentWorkspace compilable

0601330

Commented out deprecated achievements reducers. Those in RequestsSaga…

1abe67f

… were previously commented out already

Make DefaultChapterSelect compilable. Updated changeSublanguage reduc…

7072c82

…er to use postCourseConfig saga

Make Playground compilable. Removed effect which fetches default subl…

54d1e18

…anguage on first render

Yarn format

691b66f

Make InsertFakeAchievements compilable. Note that achievements might …

051d3db

…be hardcoded to assessement types

Make EditingWorkspace compilable

e4398e9

Make BackendMocks compilable

133d7c5

chownces added 3 commits July 28, 2021 17:04

Fix miscellaneous stuff after self-review

0af1e9a

Updated MCQ blocking and no solution progress. Other Miscellaneous fixes

f853e59

Merge branch 'master' into multitenant/dev

d6e1d7e

chownces requested a review from angelsl July 28, 2021 10:09

This was linked to issues Jul 28, 2021

SA@NUS: Help not customizable #1858

Closed

User profile cannot be closed on mobile #1813

Closed

chownces commented Jul 28, 2021

View reviewed changes

chownces added 3 commits July 29, 2021 19:01

Merge branch 'master' into multitenant/dev

bb8c585

Update delete assessment config endpoint

5608e68

Handle case where user has courses, but backend has no latestViewedCo…

bdef2b0

…urse for this user

chownces mentioned this pull request Jul 30, 2021

Upgrades to Achievements UI and removal of Achievement categories #1886

Merged

4 of 7 tasks

This was referenced Aug 1, 2021

Game sounds and anims fixes #1890

Merged

Game assessments state refreshes #1891

Merged

angelsl requested changes Aug 1, 2021

View reviewed changes

chownces added 3 commits August 2, 2021 15:41

Refactor AdminPanel typing with KeysOfType helper

89363e0

Remove NUS hardcoded stuff. Added deployment name config in .env. use…

acae905

…Selector in Welcome Page. Fix miscellaneous typos

Add CSV error line number

563ae6d

chownces force-pushed the multitenant/dev branch from 6031a71 to be5920b Compare August 2, 2021 10:18

Refactor playground language switching

47a4b6e

chownces force-pushed the multitenant/dev branch from be5920b to 47a4b6e Compare August 2, 2021 13:06

Merge branch 'master' into multitenant/dev

1703a6f

angelsl approved these changes Aug 3, 2021

View reviewed changes

angelsl merged commit c8e5c30 into source-academy:multitenant/dev Aug 3, 2021

This was referenced Aug 4, 2021

SA@NUS: Help not customizable #1858

Closed

User profile cannot be closed on mobile #1813

Closed

Redirect to 404 if assessment or question is not found #623

Closed

Help text should be configurable, at the time of deployment #547

Closed

zhyuhan mentioned this pull request Apr 22, 2023

Redesign Avenger dashboard #2437

Merged

Conversation

chownces commented Jul 28, 2021

Description

Status:

Changelog (Knight --> Rook):

Type of change

How to test

Checklist

Uh oh!

chownces commented Jul 28, 2021

Uh oh!

chownces Jul 28, 2021

Choose a reason for hiding this comment

Uh oh!

angelsl Aug 1, 2021

Choose a reason for hiding this comment

Uh oh!

chownces Aug 2, 2021

Choose a reason for hiding this comment

Uh oh!

Uh oh!

chownces Jul 28, 2021

Choose a reason for hiding this comment

Uh oh!

Uh oh!

angelsl left a comment

Choose a reason for hiding this comment

Uh oh!

angelsl Aug 1, 2021

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

angelsl Aug 1, 2021

Choose a reason for hiding this comment

Uh oh!

angelsl Aug 1, 2021

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

angelsl commented Aug 1, 2021

Uh oh!

angelsl left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants