Repository navigation
Fix 403 error popup on page load - #2635
Merged
Merged
Conversation
* Grading overview data should be dispatched in Grading component instead of main Academy component * Respective code has been moved over accordingly
Pull Request Test Coverage Report for Build 5910953297
💛 - Coveralls |
RichDom2185
approved these changes
Aug 19, 2023
RichDom2185
left a comment
RichDom2185
left a comment
Member
There was a problem hiding this comment.
LGTM, thanks a lot!
@chownces Looks good, but could I just run it through you first? If all is okay, feel free to merge. I'll rebase my other PRs accordingly.
Contributor
|
Yup the bug was introduced in the Avenger Dashboard redesign PR (#2437). The fetching of grading overviews was put in the wrong component. @RichDom2185 I've tested this fix on my side as well and it looks good! |
RichDom2185
enabled auto-merge (squash)
August 21, 2023 06:15
RichDom2185
pushed a commit
to NUS-CS1101S/cadet-frontend
that referenced
this pull request
Aug 25, 2023
* Grading overview data should be dispatched in Grading component instead of main Academy component * Respective code has been moved over accordingly
RichDom2185
pushed a commit
to NUS-CS1101S/cadet-frontend
that referenced
this pull request
Aug 25, 2023
* Grading overview data should be dispatched in Grading component instead of main Academy component * Respective code has been moved over accordingly
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The PR fixes a bug which shows a 403 error popup every single time a page in the academy tab has been loaded (see image below).
Error popup
This bug had likely been introduced in the commit 05cad2b, where
src/pages/academy/Academy.tshas a new dispatch effect added upon component loading. Grading overview data should be fetched in grading pages instead of main academy pages.However, this fix has only been experimentally-tested locally, and further verification is required to ensure no regression towards the grading page(s).
Type of change
How to test
After running, ensure the frontend does not make an request to
<API>/v2/courses/<course_id>/admin/grading?group=false(in browser console), and that the grading page(s) works normally.Checklist