Upgrade to Blueprint v5 by RichDom2185 · Pull Request #2718 · source-academy/frontend

RichDom2185 · 2023-12-08T13:07:35Z

Description

Upgrades the version of BlueprintJS and related dependencies to v5 to future-proof the platform.

Supersedes Update dependency @blueprintjs/datetime to v5 - autoclosed #2735
Supersedes Update dependency @blueprintjs/icons to v5 - autoclosed #2736
Supersedes Update dependency @blueprintjs/popover2 to v2 - autoclosed #2737
Supersedes Update dependency @blueprintjs/core to v5 - autoclosed #2767
Supersedes Update dependency @blueprintjs/select to v5 - autoclosed #2768

Type of change

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
This change requires a documentation update
Code quality improvements

How to test

All components work and look correct.

Checklist

I have tested this code
I have updated the documentation

Done as per migration guide.

Fixes a compile error following the version upgrade.

Resolves the issue with the deprecated `DateInput` component. Also made the necessary API changes for the migration.

Fixes the breaking change introduced by the Blueprint v5 upgrade.

RichDom2185 · 2023-12-08T13:08:06Z

Despite no more compile errors, there are still some UI regressions, thus I'm keeping this PR as draft for now.

chownces · 2024-01-16T03:56:42Z

Despite no more compile errors, there are still some UI regressions, thus I'm keeping this PR as draft for now.

Do you recall what are the UI regressions here?

RichDom2185 · 2024-01-16T03:59:10Z

Despite no more compile errors, there are still some UI regressions, thus I'm keeping this PR as draft for now.

Do you recall what are the UI regressions here?

Yes, some tables/styles look wrong. I believe they might be because of conflicts with our custom stylesheets, but I have yet to look into them in more detail.

Though notably, the date/time picker component has been revamped in v5, so the UX there suffered a lot too (though I believe functionality still works).

…y-frontend into upgrade-to-blueprint-v5

Update the target classes to match the new components.

RichDom2185

I'm of the opinion that we should merge this ASAP so that the CP3108 frontend teams can test and perhaps report bugs in the styles (if any) before it's actually deployed for the next semester.

Thoughts? @chownces @sayomaki

coveralls · 2024-02-09T07:20:01Z

Pull Request Test Coverage Report for Build 7862853337

-5 of 6 (16.67%) changed or added relevant lines in 4 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 37.204%

Changes Missing Coverage	Changed/Added Lines	%
src/features/remoteExecution/RemoteExecutionDeviceDialog.tsx	1	0.0%
src/pages/academy/groundControl/subcomponents/GroundControlEditCell.tsx	2	0.0%
src/pages/academy/storySimulator/subcomponents/StorySimulatorAssetSelection.tsx	2	0.0%

Totals
Change from base Build 7862778078:	0.0%
Covered Lines:	5723
Relevant Lines:	14458

💛 - Coveralls

sayomaki

LGTM so far, thanks! Let's approve and merge this, so that users are able to test the interface and look out for any missed regressions.

* Replace deprecated `ITreeNode` with `TreeNodeInfo` Done as per migration guide. * Upgrade BlueprintJS dependencies to v5 * Use public `IconName` type instead of internal API Fixes a compile error following the version upgrade. * Migrate to `Datetime2` package Resolves the issue with the deprecated `DateInput` component. Also made the necessary API changes for the migration. * Update prop name Fixes the breaking change introduced by the Blueprint v5 upgrade. * Update test snapshots * Reran `yarn install` post-merge * Update snapshots post-merge * Update SCSS namespace * Fix popover styles Update the target classes to match the new components. * Revert Env Vizualiser snapshot change * Fix TreeNode comparison to compare id instead of object reference --------- Co-authored-by: sayomaki <sayomayomaki@gmail.com>

RichDom2185 added 5 commits December 8, 2023 18:17

Replace deprecated ITreeNode with TreeNodeInfo

940395d

Done as per migration guide.

Upgrade BlueprintJS dependencies to v5

a16c5eb

Use public IconName type instead of internal API

9382735

Fixes a compile error following the version upgrade.

Migrate to Datetime2 package

584f149

Resolves the issue with the deprecated `DateInput` component. Also made the necessary API changes for the migration.

Update prop name

f93754a

Fixes the breaking change introduced by the Blueprint v5 upgrade.

RichDom2185 requested a review from chownces December 8, 2023 13:07

RichDom2185 self-assigned this Dec 8, 2023

RichDom2185 added 2 commits December 8, 2023 20:36

Update test snapshots

2215ecc

Merge branch 'master' into upgrade-to-blueprint-v5

3246aad

RichDom2185 added 8 commits January 16, 2024 11:59

Merge branch 'master' into upgrade-to-blueprint-v5

63a7b49

Merge branch 'master' of https://github.com/RichDom2185/source-academ…

4c18ba9

…y-frontend into upgrade-to-blueprint-v5

Reran yarn install post-merge

2bb9c53

Update snapshots post-merge

3767fbc

Merge branch 'master' of https://github.com/RichDom2185/source-academ…

4c19d5f

…y-frontend into upgrade-to-blueprint-v5

Update SCSS namespace

00c8ab6

Fix popover styles

941ab7c

Update the target classes to match the new components.

Revert Env Vizualiser snapshot change

ea51489

RichDom2185 requested a review from sayomaki February 8, 2024 18:00

RichDom2185 commented Feb 8, 2024

View reviewed changes

Fix TreeNode comparison to compare id instead of object reference

312282c

RichDom2185 marked this pull request as ready for review February 9, 2024 07:43

RichDom2185 added 4 commits February 9, 2024 16:04

Merge branch 'master' into upgrade-to-blueprint-v5

6dc8191

Merge branch 'master' into upgrade-to-blueprint-v5

e5c0ac2

Merge branch 'master' into upgrade-to-blueprint-v5

8b1e621

Merge branch 'master' into upgrade-to-blueprint-v5

c8ce75f

sayomaki approved these changes Feb 12, 2024

View reviewed changes

RichDom2185 merged commit 7011a41 into source-academy:master Feb 12, 2024

RichDom2185 mentioned this pull request Feb 12, 2024

Bump BlueprintJS to v5 source-academy/modules#275

Merged

3 of 6 tasks

RichDom2185 mentioned this pull request Feb 20, 2024

Incorrect CSS namespace in hardcoded frontend classes #2797

Closed

Navigation Menu

Repository navigation

Upgrade to Blueprint v5 - #2718

Upgrade to Blueprint v5#2718
RichDom2185 merged 20 commits into
source-academy:masterfrom
RichDom2185:upgrade-to-blueprint-v5

RichDom2185 commented Dec 8, 2023 •

edited

Loading

Uh oh!

RichDom2185 commented Dec 8, 2023

Uh oh!

chownces commented Jan 16, 2024

Uh oh!

RichDom2185 commented Jan 16, 2024

Uh oh!

RichDom2185 left a comment

Uh oh!

coveralls commented Feb 9, 2024 •

edited

Loading

Uh oh!

sayomaki left a comment

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

RichDom2185 commented Dec 8, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Type of change

How to test

Checklist

Uh oh!

RichDom2185 commented Dec 8, 2023

Uh oh!

chownces commented Jan 16, 2024

Uh oh!

RichDom2185 commented Jan 16, 2024

Uh oh!

RichDom2185 left a comment

Choose a reason for hiding this comment

Uh oh!

coveralls commented Feb 9, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pull Request Test Coverage Report for Build 7862853337

💛 - Coveralls

Uh oh!

sayomaki left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

RichDom2185 commented Dec 8, 2023 •

edited

Loading

coveralls commented Feb 9, 2024 •

edited

Loading