Skip to content

Remove grading summary - #2790

Merged
martin-henz merged 5 commits into
masterfrom
remove-grading-summary
Feb 20, 2024
Merged

martin-henz merged 5 commits into
masterfrom
remove-grading-summary

Conversation

@RichDom2185

Copy link
Copy Markdown
Member

Description

Removes the grading summary card introduced in #2437 as per offline discussions

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Code quality improvements

Checklist

  • I have tested this code
  • I have updated the documentation

Move menu options outside component, preventing unnecessary object
recreations.
@RichDom2185 RichDom2185 self-assigned this Feb 18, 2024
@coveralls

coveralls commented Feb 18, 2024 •

Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 7979070536

Details

  • -7 of 7 (0.0%) changed or added relevant lines in 1 file are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.04%) to 37.062%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/pages/academy/grading/Grading.tsx 0 7 0.0%
Files with Coverage Reduction New Missed Lines %
src/pages/academy/grading/Grading.tsx 2 0.0%
Totals Coverage Status
Change from base Build 7978981126: 0.04%
Covered Lines: 5752
Relevant Lines: 14609

💛 - Coveralls

@martin-henz
martin-henz self-requested a review February 20, 2024 21:42

@martin-henz martin-henz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@martin-henz
martin-henz merged commit 4143b87 into master Feb 20, 2024
@martin-henz
martin-henz deleted the remove-grading-summary branch February 20, 2024 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants