Skip to content

Fix reversed condition for filtering by group - #3019

Merged
RichDom2185 merged 1 commit into
source-academy:masterfrom
sayomaki:sayomaki-patch
Aug 15, 2024
Merged

RichDom2185 merged 1 commit into
source-academy:masterfrom
sayomaki:sayomaki-patch

Conversation

@sayomaki

@sayomaki sayomaki commented Aug 15, 2024 •

Copy link
Copy Markdown
Contributor

Description

Right now in the Grading tab of the Academy, the default filter (of all groups) only shows submissions from the user's own groups (filter condition reversed), and this PR fixes it.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Code quality improvements

Checklist

  • I have tested this code
  • I have updated the documentation

@sayomaki
sayomaki requested a review from RichDom2185 August 15, 2024 14:41
@sayomaki sayomaki self-assigned this Aug 15, 2024
@coveralls

Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 10405611541

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 31.716%

Totals Coverage Status
Change from base Build 10405278900: 0.0%
Covered Lines: 4822
Relevant Lines: 14372

💛 - Coveralls

@RichDom2185

Copy link
Copy Markdown
Member

Regression from #2787

@RichDom2185 RichDom2185 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@RichDom2185
RichDom2185 merged commit 739895d into source-academy:master Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants