[Akshay-2007-1]

Summary

Wires up Conductor's new receiveInputRequest hook (source-academy/conductor#40) so input() in Python programs shows a popup instead of hanging silently, on both the home tab and the viz CSE Machine tab.

• New handleInputRequest saga (evalCode.ts) listens for input requests from the runner, shows the existing PromptDialog popup (showSimplePromptDialog, already used elsewhere e.g. Google Drive save), and answers via hostPlugin.sendInput.
• The home tab and the viz CSE Machine tab share the same evalCodeConductorSaga run, so this single fix covers both surfaces from the issue — no separate viz-tab handling needed.
• New isWaitingForInput workspace state, used to suspend the execTime-based execution watchdog while a popup is open (previously that raced against a small fixed window and would have killed a run mid-prompt for anyone who took a few seconds to type an answer).
• Points @sourceacademy/conductor at the local checkout via a portal: resolution for now, since the protocol change it depends on isn't released yet.

Depends on

• Add input-request signal to the IO protocol for input() conductor#40 (merge + release needed first — an npm publish, since this repo pins conductor via semver)
• input(): forward prompt through Conductor and flush pending stdout py-slang#254 (draft, same dependency, needs a bit more py-slang-side work to fully populate the prompt text shown in the popup)

Opening as draft: CI will fail on yarn install until conductor#40 is released and this branch's portal: pin is swapped for the real version — same situation as py-slang#254.

Test plan

• Full project tsc --noEmit passes clean
• Manual verification of the popup flow (submit/cancel/timeout-pause/interrupt) pending the conductor release and repin — not runnable against a portal:-only dependency in CI

[coderabbitai]

Important

Review skipped

Auto incremental reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 15be3b60-33c1-48d0-b13e-7f84eb0d9015

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

Walkthrough

Changes

Interactive conductor input

Layer / File(s)	Summary
Input-waiting state contract package.json, src/commons/application/..., src/commons/workspace/...	The conductor dependency now targets version 0.6.0, and workspace state, initialization, actions, and reducer handling include isWaitingForInput.
Conductor input request flow src/commons/sagas/WorkspaceSaga/helpers/evalCode.ts	Conductor evaluations handle input requests with blocking prompts, send responses through hostPlugin, suspend watchdog timeouts while waiting, and cancel the input listener during teardown.

Estimated code review effort: 3 (Moderate) | ~25 minutes

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly describes the main change: showing a popup for input() requests instead of hanging.
Description check	✅ Passed	The description covers the summary, dependencies, and test plan, and is mostly aligned with the template despite omitting explicit type-of-change and checklist sections.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[gemini-code-assist]

Code Review

This pull request introduces support for handling standard-input requests (such as Python's input()) in the runner. It adds state and actions to track when the workspace is waiting for input, implements a saga handleInputRequest to display a prompt dialog and send the user's input back to the runner, and updates the execution watchdog to suspend its timeout while waiting for input. A critical issue was identified where a rejection of the prompt dialog (e.g., if dismissed) would crash the saga and cause the runner to hang indefinitely; wrapping the dialog call in a try-catch block is recommended to handle this gracefully.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

[coveralls]

Coverage Report for CI Build 29081135790

Coverage decreased (-0.09%) to 42.267%

Details

• Coverage decreased (-0.09%) from the base build.
• Patch coverage: 31 uncovered changes across 3 files (0 of 31 lines covered, 0.0%).
• 1 coverage regression across 1 file.

Uncovered Changes

File	Changed	Covered	%
src/commons/sagas/WorkspaceSaga/helpers/evalCode.ts	28	0	0.0%
src/commons/workspace/WorkspaceReducer.ts	2	0	0.0%
src/commons/application/actions/InterpreterActions.ts	1	0	0.0%

Coverage Regressions

1 previously-covered line in 1 file lost coverage.

File	Lines Losing Coverage	Coverage
src/commons/sagas/WorkspaceSaga/helpers/evalCode.ts	1	33.33%

---

Coverage Stats

Relevant Lines:	14172
Covered Lines:	6440
Line Coverage:	45.44%
Relevant Branches:	7540
Covered Branches:	2737
Branch Coverage:	36.3%
Branches in Coverage %:	Yes
Coverage Strength:	28.09 hits per line

---

💛 - Coveralls

[coderabbitai]

Actionable comments posted: 1

🧹 Nitpick comments (1)

package.json (1)

50-50: 📐 Maintainability & Code Quality | 🔵 Trivial

Keep this Git ref temporary until @sourceacademy/conductor@0.6.0 is published. Switch back to the npm release once it exists so installs regain registry integrity and reproducibility.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@package.json` at line 50, Update the `@sourceacademy/conductor` dependency in
package.json from the temporary Git URL reference back to the published npm
version `@sourceacademy/conductor`@0.6.0 once that release is available.

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@src/commons/sagas/WorkspaceSaga/helpers/evalCode.ts`:
- Around line 739-762: Update the timeout branch inside the timeout saga to
resolve a truthy value, such as true, or replace it with a delay effect, so the
existing if (timedOut) condition reliably returns. Preserve the input-wait
handling and fresh timeout behavior in the surrounding race and follow-up take.

---

Nitpick comments:
In `@package.json`:
- Line 50: Update the `@sourceacademy/conductor` dependency in package.json from
the temporary Git URL reference back to the published npm version
`@sourceacademy/conductor`@0.6.0 once that release is available.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 016eefc3-ad84-4fbe-b85f-f3542c892076

📥 Commits

Reviewing files that changed from the base of the PR and between decc358 and efd8a3d.

⛔ Files ignored due to path filters (1)

• yarn.lock is excluded by !**/yarn.lock, !**/*.lock

📒 Files selected for processing (6)

• package.json
• src/commons/application/ApplicationTypes.ts
• src/commons/application/actions/InterpreterActions.ts
• src/commons/sagas/WorkspaceSaga/helpers/evalCode.ts
• src/commons/workspace/WorkspaceReducer.ts
• src/commons/workspace/WorkspaceTypes.ts

[coderabbitai]

🩺 Stability & Availability | 🟠 Major | ⚡ Quick win

🧩 Analysis chain

🌐 Web query:

redux-saga race result undefined when winning effect resolves undefined

💡 Result:

In redux-saga, when you use the race effect, it returns an object where keys correspond to the keys you provided in the input object [1]. If the winning effect resolves to undefined, the resulting object will contain that key with a value of undefined [1][2]. Because the result of the race is an object where all losing effects are set to undefined and only the winning effect holds its resolved value, a common pitfall occurs when checking for the result [1][2]. If you use a truthy check (e.g., if (result.key)) to determine if an effect won, that check will fail if the winning effect resolved to undefined, even though it was indeed the winner [3][2]. To correctly handle this, you should check for the presence of the key in the result object rather than the truthiness of its value. You can use the in operator or Object.prototype.hasOwnProperty.call to confirm which effect won [3][2]. Example: const result = yield race({ task: call(myFunction), cancel: take('CANCEL') }); // Avoid: if (result.task) {... } // If myFunction resolves to undefined, this will be false even if it won. // Use: if ('task' in result) { // Handle successful resolution of task, even if the value is undefined } if ('cancel' in result) { // Handle cancellation }

Citations:

• 1: https://github.com/redux-saga/redux-saga/blob/24e9a68d621fd2a57a29b3b80e4b54ecb22fa593/packages/core/types/effects.d.ts
• 2: Typing race TS 3.6 redux-saga/redux-saga#1900
• 3: https://stackoverflow.com/questions/51388284/redux-sagas-race-wont-trigger

---

🏁 Script executed:

#!/bin/bash
set -euo pipefail

# Map the relevant file structure first
ast-grep outline src/commons/sagas/WorkspaceSaga/helpers/evalCode.ts --view expanded

# Read the watchdog block and nearby control flow
sed -n '700,810p' src/commons/sagas/WorkspaceSaga/helpers/evalCode.ts

# Find any uses of redux-saga delay / race in this file for comparison
rg -n "race\\(|delay\\(|setTimeout\\(|isWaitingForInput" src/commons/sagas/WorkspaceSaga/helpers/evalCode.ts

Repository: source-academy/frontend

Length of output: 5736

---

Make the watchdog timeout branch truthy

setTimeout(resolve, ...) resolves timedOut to undefined, so if (timedOut) never fires and the saga can hang in the follow-up take(...) instead of stopping a runaway run. Use a truthy resolution here (or delay).

Proposed fix

-            timedOut: call(() => new Promise(resolve => setTimeout(resolve, execTime + 10000))),
+            timedOut: call(() => new Promise(resolve => setTimeout(() => resolve(true), execTime + 10000))),

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change

	timeout: call(function* (): SagaIterator {
	while (true) {
	const { timedOut } = yield race({
	timedOut: call(() => new Promise(resolve => setTimeout(resolve, execTime + 10000))),
	waiting: take(
	(a: any) =>
	a.type === actions.setIsWaitingForInput.type &&
	a.payload.workspaceLocation === workspaceLocation &&
	a.payload.isWaitingForInput === true,
	),
	});
	if (timedOut) {
	return;
	}
	// Waiting on the input() popup: suspend the watchdog entirely until it's answered,
	// then restart a fresh execTime window.
	yield take(
	(a: any) =>
	a.type === actions.setIsWaitingForInput.type &&
	a.payload.workspaceLocation === workspaceLocation &&
	a.payload.isWaitingForInput === false,
	);
	}
	}),
	timeout: call(function* (): SagaIterator {
	while (true) {
	const { timedOut } = yield race({
	timedOut: call(() => new Promise(resolve => setTimeout(() => resolve(true), execTime + 10000))),
	waiting: take(
	(a: any) =>
	a.type === actions.setIsWaitingForInput.type &&
	a.payload.workspaceLocation === workspaceLocation &&
	a.payload.isWaitingForInput === true,
	),
	});
	if (timedOut) {
	return;
	}
	// Waiting on the input() popup: suspend the watchdog entirely until it's answered,
	// then restart a fresh execTime window.
	yield take(
	(a: any) =>
	a.type === actions.setIsWaitingForInput.type &&
	a.payload.workspaceLocation === workspaceLocation &&
	a.payload.isWaitingForInput === false,
	);
	}
	}),

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/commons/sagas/WorkspaceSaga/helpers/evalCode.ts` around lines 739 - 762,
Update the timeout branch inside the timeout saga to resolve a truthy value,
such as true, or replace it with a delay effect, so the existing if (timedOut)
condition reliably returns. Preserve the input-wait handling and fresh timeout
behavior in the surrounding race and follow-up take.

[martin-henz]

Nice example of conductor in action!