fix(backend): pass zoekt index args without shell

[brendan-kellam]

Fixes SOU-1462

Summary

• Pass zoekt index parameters via argv instead of a composed command string.
• Add backend coverage for revision names with punctuation.

Tests

• yarn workspace @sourcebot/backend test
• yarn workspace @sourcebot/backend build

Summary by CodeRabbit

• Bug Fixes

  • Fixed Zoekt indexing so revision names with punctuation and special characters are preserved correctly.
  • Improved how indexing parameters are passed to avoid issues caused by shell command parsing.

• Tests

  • Added coverage for Zoekt indexing to verify the expected arguments are sent during repository indexing.

[coderabbitai]

Walkthrough

indexGitRepository in zoekt.ts switches from building a shell command string with exec to constructing an explicit args array with execFile. A new test file verifies the resulting argument list, including preservation of branch names with punctuation. A changelog entry documents the fix.

Changes

exec → execFile refactor with test

Layer / File(s)	Summary
Switch indexGitRepository from exec to execFile packages/backend/src/zoekt.ts	Imports execFile instead of exec; replaces shell-string command assembly with a discrete args array passed to execFile('zoekt-git-index', args, { signal }, ...).
Test execFile argument correctness with special-character branches packages/backend/src/zoekt.test.ts, CHANGELOG.md	New test suite mocks execFile and helpers, then asserts indexGitRepository passes the exact expected argument array to zoekt-git-index, including a branch name with punctuation. Changelog entry documents the fix.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

• sourcebot-dev/sourcebot#773: Modifies the same indexGitRepository subprocess argument construction in zoekt.ts, specifically around ALWAYS_INDEX_FILE_PATTERNS quoting and -large_file argument handling.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly matches the main change: backend Zoekt index arguments now go through argv instead of a shell string.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch brendan/fix-SOU-1462

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@packages/backend/src/zoekt.ts`:
- Line 22: The branch list handling in zoekt.ts still serializes revisions with
a comma delimiter, which breaks refs that contain literal commas. Update the
logic around the revisions.join(',') usage in the zoekt-git-index argument
builder to either encode values so commas round-trip safely or explicitly reject
comma-containing refs before invoking the command, and add a regression test
covering a ref like refs/heads/release,1 to lock in the behavior.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 16a6eede-626d-439f-a4af-cb2bed44d19b

📥 Commits

Reviewing files that changed from the base of the PR and between d546511 and 86b0746.

📒 Files selected for processing (3)

• CHANGELOG.md
• packages/backend/src/zoekt.test.ts
• packages/backend/src/zoekt.ts