chore: upgrade golang.org/x/text to v0.39.0 to address CVE-2026-56852 - #1535
Merged
Conversation
Advance vendor/zoekt to include golang.org/x/text v0.39.0, which fixes the norm.Iter infinite loop on invalid UTF-8 input.\n\nResolves SOU-1751.
This comment has been minimized.
This comment has been minimized.
Contributor
WalkthroughThe PR updates the bundled Zoekt submodule and adds an Unreleased changelog entry for its ChangesZoekt submodule update
Estimated code review effort: 1 (Trivial) | ~3 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes SOU-1751
Summary
vendor/zoektthrough sourcebot-dev/zoekt#19golang.org/x/textfromv0.37.0to the patchedv0.39.0norm.Itercan enter an infinite loop on invalid UTF-8 inputThe submodule advance also includes the intervening Zoekt workflow repair from sourcebot-dev/zoekt#18.
Verification
go mod verifyinvendor/zoektgo build -C vendor/zoekt -o /private/tmp/sourcebot-sou-1751-bin ./cmd/...git diff --checkNote
Low Risk
Dependency-only change in the Zoekt submodule with a targeted patch for a known CVE; risk is low assuming Zoekt builds and indexing behave as before.
Overview
Security dependency bump for the vendored Zoekt search engine: the
vendor/zoektsubmodule is advanced (including upstream Zoekt workflow fixes from sourcebot-dev/zoekt#18–#19), andgolang.org/x/textis upgraded from v0.37.0 to v0.39.0.This addresses CVE-2026-56852, where
norm.Itercould hang in an infinite loop on invalid UTF-8 input. No application logic changes in the main monorepo beyond the submodule pointer and transitive Go module versions used when building Zoekt binaries.Reviewed by Cursor Bugbot for commit e090f25. Bugbot is set up for automated code reviews on this repo. Configure here.