Skip to content

Update email schema to use format-assertion - #100

Merged
jviotti merged 1 commit into
mainfrom
better-mail
Jul 27, 2026
Merged

Update email schema to use format-assertion#100
jviotti merged 1 commit into
mainfrom
better-mail

Conversation

@jviotti

@jviotti jviotti commented Jul 27, 2026

Copy link
Copy Markdown
Member

Signed-off-by: Juan Cruz Viotti jv@jviotti.com

Review in cubic

Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>
@jviotti
jviotti merged commit a039cad into main Jul 27, 2026
3 checks passed
@jviotti
jviotti deleted the better-mail branch July 27, 2026 13:13
@augmentcode

augmentcode Bot commented Jul 27, 2026

Copy link
Copy Markdown
🤖 Augment PR Summary

Summary: This PR updates the IETF email address schema to use the library’s JSON Schema 2020-12 format-assertion dialect so format: "email" is enforced during validation.
Changes:

  • Switch $schema to the urn:sourcemeta:…:dialect:format-assertion dialect and remove the custom regex-based constraints.
  • Refresh schema metadata (RFC link/title) and tweak the examples list.
  • Update the email test corpus expectations to match asserted format behavior (e.g., comments/domain-literal/numeric TLD cases).

🤖 Was this summary useful? React with 👍 or 👎

@augmentcode augmentcode Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. 1 suggestion posted.

Fix All in Augment

Comment augment review to trigger a new review at any time.

"$schema": "https://json-schema.org/draft/2020-12/schema",
"title": "RFC 5322 Email Address (Addr-Spec)",
"$schema": "urn:sourcemeta:std:ietf:jsonschema:2020-12:dialect:format-assertion",
"title": "RFC 5321 Email Address (Addr-Spec)",

@augmentcode augmentcode Bot Jul 27, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The title references RFC 5321 but also calls the syntax “Addr-Spec”, which is RFC 5322 terminology (RFC 5321 §4.1.2 describes a Mailbox/Local-part@Domain). Consider aligning the title/link/terminology to a single RFC to avoid misleading consumers about the intended grammar.

Severity: low

Fix This in Augment

🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant