Update email schema to use format-assertion - #100
Merged
Merged
Conversation
Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>
🤖 Augment PR SummarySummary: This PR updates the IETF email address schema to use the library’s JSON Schema 2020-12
🤖 Was this summary useful? React with 👍 or 👎 |
| "$schema": "https://json-schema.org/draft/2020-12/schema", | ||
| "title": "RFC 5322 Email Address (Addr-Spec)", | ||
| "$schema": "urn:sourcemeta:std:ietf:jsonschema:2020-12:dialect:format-assertion", | ||
| "title": "RFC 5321 Email Address (Addr-Spec)", |
There was a problem hiding this comment.
The title references RFC 5321 but also calls the syntax “Addr-Spec”, which is RFC 5322 terminology (RFC 5321 §4.1.2 describes a Mailbox/Local-part@Domain). Consider aligning the title/link/terminology to a single RFC to avoid misleading consumers about the intended grammar.
Severity: low
🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Juan Cruz Viotti jv@jviotti.com