Repository navigation
feat(cli): name-based filters for builds and events, singular nouns, and shell completions - #424
Open
PiquelChips wants to merge 1 commit into
Open
PiquelChips wants to merge 1 commit into
PiquelChips wants to merge 1 commit into
Conversation
Contributor
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 57 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
PiquelChips
marked this pull request as ready for review
November 10, 2026 18:04
PiquelChips
force-pushed
the
feat/cli-build-event
branch
4 times, most recently
from
November 12, 2026 15:14
2ef096c to
d216434
Compare
…and shell completions - `builds` and `events` become `build` and `event`; the plurals stay as hidden aliases. - Both filter with `--app` and `--env` by name or ID, like other commands. An ID alone still finds a deleted application's or environment's history. `--application` and `--environment` stay as hidden aliases. - `event` lists newest first, like `build list` and `audit`. - `build list` takes `--limit`. - `piquelctl completions <SHELL>` prints a completion script through `clap_complete`, and the Nix package installs the bash, fish and zsh ones.
PiquelChips
force-pushed
the
feat/cli-build-event
branch
from
November 12, 2026 21:30
d216434 to
a2ac685
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
buildsandeventswere the odd ones out. They used plural nouns, took only IDs through--application/--environmentwhere every other command takes names through--app/--env, and listed oldest first.build listalso had no--limit, and there were no shell completions.buildandevent, withbuildsandeventskept as hidden aliases so scripts keep working.--app/--env: a sharedHistoryScopelooks each value up by ID, then by name, like other commands. A value neither finds is sent as an ID when it is shaped like one, so a deleted application's or environment's history stays reachable; otherwise it is not found.--envalone takes an ID.--applicationand--environmentremain hidden aliases.eventis newest first, through the API's existingdescendingfilter (client.eventskeeps its oldest-first order).build list --limit, through the API's existinglimit. The client'sbuildstakes an optional limit, and the dashboard passesNone.piquelctl completions <SHELL>: it adds one dependency,clap_complete, from the clap maintainers (cargo denypasses). It runs before profiles, likeapp validate. The Nix package installs the bash, fish and zsh scripts in native builds.Guides and
cli.mduse the new commands, and the CLI reference was regenerated.Proof: the events and builds tests now cover the new nouns and flags, name resolution (including a name of ID length and
--app NAME --env NAME), the deleted-ID fallback, the hidden aliases,--limitanddescending=true, andcompletions bashprints a script.nix build .#cliinstallsshare/{bash-completion,fish,zsh}completions.cargo nextest run -p piquelctl -p piqueld-client(147),just lint(native and wasm),cargo deny checkand fmt pass.Note
Written by Claude Opus 5.5 in Claude Code and reviewed by Claude Opus 5.5 (via T3 Code)
🤖 Generated with Claude Code