Skip to content

feat(cli): name-based filters for builds and events, singular nouns, and shell completions - #424

Open
PiquelChips wants to merge 1 commit into
mainfrom
feat/cli-build-event
Open

PiquelChips wants to merge 1 commit into
mainfrom
feat/cli-build-event

Conversation

@PiquelChips

@PiquelChips PiquelChips commented Nov 10, 2026 •

Copy link
Copy Markdown
Member

builds and events were the odd ones out. They used plural nouns, took only IDs through --application/--environment where every other command takes names through --app/--env, and listed oldest first. build list also had no --limit, and there were no shell completions.

  • Singular nouns (D6): build and event, with builds and events kept as hidden aliases so scripts keep working.
  • Names, through --app/--env: a shared HistoryScope looks each value up by ID, then by name, like other commands. A value neither finds is sent as an ID when it is shaped like one, so a deleted application's or environment's history stays reachable; otherwise it is not found. --env alone takes an ID. --application and --environment remain hidden aliases.
  • event is newest first, through the API's existing descending filter (client.events keeps its oldest-first order).
  • build list --limit, through the API's existing limit. The client's builds takes an optional limit, and the dashboard passes None.
  • piquelctl completions <SHELL>: it adds one dependency, clap_complete, from the clap maintainers (cargo deny passes). It runs before profiles, like app validate. The Nix package installs the bash, fish and zsh scripts in native builds.

Guides and cli.md use the new commands, and the CLI reference was regenerated.

Proof: the events and builds tests now cover the new nouns and flags, name resolution (including a name of ID length and --app NAME --env NAME), the deleted-ID fallback, the hidden aliases, --limit and descending=true, and completions bash prints a script. nix build .#cli installs share/{bash-completion,fish,zsh} completions. cargo nextest run -p piquelctl -p piqueld-client (147), just lint (native and wasm), cargo deny check and fmt pass.

Note

Written by Claude Opus 5.5 in Claude Code and reviewed by Claude Opus 5.5 (via T3 Code)

🤖 Generated with Claude Code

@coderabbitai

coderabbitai Bot commented Nov 10, 2026 •

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 57 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 773f4cf2-b60b-4af3-a02d-de2933633d2e
Commits

Reviewing files that changed from the base of the PR and between 3ae88fe and a2ac685.

Files ignored due to path filters: 1

  • Cargo.lock is excluded by !**/*.lock
Files selected for processing: 19

  • Cargo.toml
  • apps/piquelctl/Cargo.toml
  • apps/piquelctl/src/cli.rs
  • apps/piquelctl/src/commands.rs
  • apps/piquelctl/src/error.rs
  • apps/piquelctl/src/lib.rs
  • apps/piquelctl/tests/cli.rs
  • apps/piqueld-ui/src/browser/builds.rs
  • apps/piqueld/tests/api_contract/transport.rs
  • crates/piqueld-client/src/builds.rs
  • docs/dev/publishing.md
  • docs/dev/quickstart.md
  • docs/user/applications/deploy-on-push.md
  • docs/user/applications/git-builds.md
  • docs/user/applications/jobs.md
  • docs/user/operations/history.md
  • docs/user/reference/cli-commands.md
  • docs/user/reference/cli.md
  • flake.nix
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@PiquelChips
PiquelChips marked this pull request as ready for review November 10, 2026 18:04
@PiquelChips
PiquelChips force-pushed the feat/cli-build-event branch 4 times, most recently from 2ef096c to d216434 Compare November 12, 2026 15:14
…and shell completions

- `builds` and `events` become `build` and `event`; the plurals stay as
  hidden aliases.
- Both filter with `--app` and `--env` by name or ID, like other commands.
  An ID alone still finds a deleted application's or environment's history.
  `--application` and `--environment` stay as hidden aliases.
- `event` lists newest first, like `build list` and `audit`.
- `build list` takes `--limit`.
- `piquelctl completions <SHELL>` prints a completion script through
  `clap_complete`, and the Nix package installs the bash, fish and zsh ones.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Needs Triage

Development

Successfully merging this pull request may close these issues.

1 participant