Repository navigation
feat(builds): fail fast with builder_unavailable when the build machine is off - #432
Draft
PiquelChips wants to merge 1 commit into
Draft
PiquelChips wants to merge 1 commit into
PiquelChips wants to merge 1 commit into
Conversation
Contributor
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
…ne is off Before each build, the host checks that the build machine's BuildKit daemon accepts a connection. When it doesn't, the deployment fails with builder_unavailable, or, with build.unavailable = "local", builds on the host instead. Closes #406.
PiquelChips
force-pushed
the
feat/builds-builder-unavailable
branch
from
November 13, 2026 13:53
d973b22 to
9c2ad10
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the build machine (#428) is off, a deployment that has to build waited about 20 seconds for Buildx, then failed with
git_build_failed, which points at the repository rather than the machine.Before each build, the host now checks that the build machine's BuildKit daemon accepts a connection, for up to 5 seconds. When it doesn't,
build.unavailabledecides:fail, the default: the deployment fails withbuilder_unavailable. Its guidance names the build machine, the CLI suggestsenv reconcile, and the build's output names the daemon it couldn't reach. It counts as a build failure for notifications.local: the image builds on the host's Docker Engine instead, and the build's output says so.Deployments that need no build never check: restores, promotions, drift repair, and deployments that reuse their images (#425).
The setting is in
config.toml, the NixOS module (with an assertion that it needsbuild.builder), the example configuration, the references, and the dashboard's Host settings.Narrower than the issue
image_unavailable, not the new code.env reconciledoes.Testing
failfailed the deployment withbuilder_unavailablewhile the service kept running, andlocalbuilt on the host.cargo nextestforpiqueld,piquelctl,piqueld-clientandpiqueld-core, Clippy for the workspace and the browser target,just openapi-check,just docs.Stacked on #428. Closes #406. Part of #403.
Note
Written by Claude Fable 5.2 and Claude Opus 5.5 in Claude Code (via T3 Code)
🤖 Generated with Claude Code