CI: Rename jobs to match branch protection requirements#273
Open
karlhillx wants to merge 2 commits into
Open
Conversation
The stacks repo currently has required checks that don't map accurately to the workflows that are being run. Specifically, the names of the jobs in CI workflows do not match the names used in protection rules, which causes PRs to be stuck waiting for a status to be reported that never arrives. This commit renames the CI jobs to match the names used in protection rules, so that their status is reported and PRs can be merged without forcing them.
ivanperez-keera
force-pushed
the
fix-job-names
branch
from
34f431a to
c051796
Compare
ivanperez-keera
force-pushed
the
fix-job-names
branch
from
860980c to
877bc41
Compare
ivanperez-keera
force-pushed
the
fix-job-names
branch
from
877bc41 to
a6150f8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #272
Description
The branch protection rules require the PR checks exactly named
MoveIt2 Docker BuildandNav2 Docker Build. However, inside.github/workflows/moveit2-build.ymland.github/workflows/nav2-build.yml, the jobs are actually namedspace-ros-moveit2andspace-ros-nav2.Because GitHub Actions automatically uses the job key as the display name (unless an explicit
name:is provided on the job), this mismatch causes GitHub to register the required checks as missing/hanging, blocking normal PR merges unless a maintainer forcefully overrides it.This PR renames the job keys in both workflows to exactly match the strings required by the branch protection rules.