Skip to content

Add spring-batch-notion#147

Merged
fmbenhassine merged 1 commit into
spring-projects:mainfrom
scordio:spring-batch-notion
Oct 28, 2024
Merged

Add spring-batch-notion#147
fmbenhassine merged 1 commit into
spring-projects:mainfrom
scordio:spring-batch-notion

Conversation

@scordio

@scordio scordio commented Oct 15, 2024

Copy link
Copy Markdown
Collaborator

See scordio/spring-batch-notion#53.

Open points:

  • Align license header to spring-batch-extensions standard
  • Update badge links in spring-batch-notion/README.md

@scordio

scordio commented Oct 15, 2024

Copy link
Copy Markdown
Collaborator Author

The CI fails with compilation errors, I'll look into them.

@scordio

scordio commented Oct 15, 2024

Copy link
Copy Markdown
Collaborator Author

The CI fails with compilation errors, I'll look into them.

It looks good now – something was wrong with spring-cloud-contract-wiremock.

Anyway, I had in mind to replace it with wiremock-spring-boot, so I grabbed the opportunity.

Comment thread .github/workflows/spring-batch-notion.yml
Comment thread README.md
@scordio scordio marked this pull request as ready for review October 15, 2024 15:51
Comment thread spring-batch-notion/pom.xml Outdated
@fmbenhassine

Copy link
Copy Markdown
Contributor

Thank you for the PR, @scordio !

Apart from the JReleaser plugin removal , it looks good to me. Please add your name as author in all files (ie add @author tag in the javadoc of all classes, tests included) as well as in the Staying in touch section of the main readme file. After that, it will be good to merge. Many thanks upfront!

@scordio

scordio commented Oct 16, 2024

Copy link
Copy Markdown
Collaborator Author

Please add your name as author in all files (ie add @author tag in the javadoc of all classes, tests included) as well as in the Staying in touch section of the main readme file.

I think everything should be done now.

Could you please allow the workflow to be executed to ensure everything works correctly in this repo and not only in my fork?

@fmbenhassine

Copy link
Copy Markdown
Contributor

Could you please allow the workflow to be executed to ensure everything works correctly in this repo and not only in my fork?

Done

@scordio

scordio commented Oct 24, 2024

Copy link
Copy Markdown
Collaborator Author

@fmbenhassine POM and CI simplified, Spring Boot version updated to the latest

Comment thread spring-batch-elasticsearch/pom.xml Outdated
Comment thread spring-batch-notion/pom.xml Outdated
Comment thread spring-batch-notion/pom.xml Outdated
Comment thread spring-batch-notion/README.md
@scordio

scordio commented Oct 25, 2024

Copy link
Copy Markdown
Collaborator Author

When releasing, would it be possible to do it with Java 21 or greater?

The Javadoc website would get goodies like the search URL (see the current one here).

@fmbenhassine

Copy link
Copy Markdown
Contributor

When releasing, would it be possible to do it with Java 21 or greater?

Sure! Please just remind me about that in the ticket you will create to request a release. Thank you.

@fmbenhassine fmbenhassine merged commit 65b2b52 into spring-projects:main Oct 28, 2024
@fmbenhassine

Copy link
Copy Markdown
Contributor

LGTM now 👍 Thank you for all these updates! Rebased and merged.

@scordio

scordio commented Oct 28, 2024

Copy link
Copy Markdown
Collaborator Author

Thanks a lot!

@scordio scordio deleted the spring-batch-notion branch October 28, 2024 14:31
@scordio scordio mentioned this pull request Nov 8, 2024
16 tasks
@scordio scordio added this to the spring-batch-notion-0.1.0 milestone Nov 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants