Repository navigation
ECS structured logging writes empty service and service.node objects - #52495
Merged
Merged
Conversation
Update `ElasticCommonSchemaProperties` to omit "service" and "service.node" objects if they have no contents. See spring-projectsgh-52495 Signed-off-by: Wei-Lun Li <b84330808@gmail.com>
philwebb
force-pushed
the
ecs-empty-service-node
branch
from
October 29, 2026 20:28
0fa07a9 to
bc9b3a1
Compare
Member
|
Thanks @b84330808 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With
logging.structured.format.console=ecs, every log line contains an emptynodeobject unlesslogging.structured.ecs.service.node-nameis set. For example, with onlyspring.application.name=app:and without any service details:
The other service members use
whenHasLength(), butserviceandservice.nodeare always written. This only writesservice.nodewhen there is a node name, and only writesservicewhen at least one of its members has a value.service.node.namekeeps the same path, so renames and excludes work as before.ElasticCommonSchemaPropertiesTests.addToJsonMembersWhenNoNodeNameDoesNotAddNodeandaddToJsonMembersWhenNoServiceValuesDoesNotAddServicefail without the change and pass with it.I used Claude Code to write this change.