Annotate DefaultCookieSerializer.setCookiePath as @Nullable - #3884
Open
zanarellidev wants to merge 1 commit into
Open
Annotate DefaultCookieSerializer.setCookiePath as @Nullable#3884zanarellidev wants to merge 1 commit into
zanarellidev wants to merge 1 commit into
Conversation
The cookiePath field and javadoc already allow null (fall back to the request context path). setSameSite already has @nullable; setCookiePath was missing it. Closes spring-projectsgh-3883 Signed-off-by: zanarelli <zanarelli.dev@gmail.com>
spring-projects-issues
added
the
status: waiting-for-triage
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DefaultCookieSerializer.setCookiePath(String)was missing@Nullableeven though the field is@Nullableand the javadoc documents null as valid. Aligns withsetSameSite(@Nullable String).Fixes #3883
Test plan
./gradlew :spring-session-core:test --tests DefaultCookieSerializerTests(existing coverage ofsetCookiePath(null))Made with Cursor