Support hexadecimal numeric literals. - #661
Merged
Merged
Conversation
JakeWharton
approved these changes
Jul 17, 2017
swankjesse
force-pushed
the
jwilson.0716.default_numbers
branch
from
July 22, 2017 13:55
68e226e to
fdd558c
Compare
Also crash with violence on octal literals. Our previous behavior was incorrect (we'd say 010 is ten and not eight) and I'd rather find out about this and fix the source rather than change the behavior with a version upgrade.
swankjesse
force-pushed
the
jwilson.0716.default_numbers
branch
from
July 22, 2017 14:35
fdd558c to
e0b1395
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also crash with violence on octal literals. Our previous behavior was
incorrect (we'd say 010 is ten and not eight) and I'd rather find out
about this and fix the source rather than change the behavior with a
version upgrade.
Closes: #655