Add expression_type and stylesheet link support to rendering extension - #28
emmanuelmathot wants to merge 3 commits into
Conversation
emmanuelmathot
changed the title
expression_type and stylesheet link support to rendering extension
| "expression": { | ||
| "type": ["string", "object", "array"] | ||
| }, | ||
| "expression_type": { | ||
| "type": "string" | ||
| }, |
There was a problem hiding this comment.
I guess the schema should ensure that expression_type is required when expression is set and vice versa. They can't really be provided alone.
| "rel": "stylesheet", | ||
| "type": "application/vnd.mapbox.style+json", | ||
| "href": "https://example.com/styles/ndvi.json", | ||
| "render": "ndvi" |
There was a problem hiding this comment.
Can we also make this usable without the render extension? So that we can just connect an asset and a style? Especially in the vector case it doesn't make a lot of sense to use render.
There was a problem hiding this comment.
It actually make sense when you want to fine tune the rendering. Check the examples.
Besides that note, I do not see what prevent a user to add a stylesheet link as of today.
There was a problem hiding this comment.
Sounds like a misunderstanding.
The way it is is fine for render, but there's no way to directly make a connection between asset (or another link) and the stylesheet. For vector you may just want t a stylesheet without the render extension, as render is primarily targeting raster data.
…t-vocabulary # Conflicts: # CHANGELOG.md # README.md
…et; update documentation for clarity
This branch has not been deployed
2 participants
Introduce
expression_typefor identifying expression dialects and add support forrel: "stylesheet"links to reference external style documents. Include a new vector data example demonstrating the extension's application on non-raster data. Update the changelog to reflect these additions.fixes #17 and #21