Vignette about loo for non factorizable models#77
Merged
Conversation
@paul-buerkner the name `params` was clashing with the knitr setting. That’s probably responsible the problem you were having.
Adding @paul-buerkner as contributor
Member
Author
|
Since this was already reviewed by all of us I'll just merge this. The website will also need to be updated separately. Right now this is just to merge the code into the master branch. |
[ci skip]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #75
Unfortunately this substantially increases the amount of time it takes to install or check the package if not ignoring the vignettes. But I think it's worth having.