[6.x] Fix CP tab crash when expanding a Bard set after a copy#14951
Draft
o1y wants to merge 3 commits into
Draft
[6.x] Fix CP tab crash when expanding a Bard set after a copy#14951o1y wants to merge 3 commits into
o1y wants to merge 3 commits into
Conversation
o1y
changed the title
Defer the set reveal by one animation frame so the nested ProseMirror editor doesn't lay out during the trusted-click turn (Chrome ≥148 CFI crash). Covers both reveal paths: expandSet() and expandAll().
Contributor
Author
|
Whoa. I'm converting this PR to a draft, as I've realized that quite a few fields are affected by this bug and proper testing is needed here. Maybe the team can take it from here. Unfortunately, we're also hitting this crash a few times a day and losing content.. I was hoping it'd be an easy fix 😅 Other reveal-on-click surfaces (collapsible sections, tabs, revealer) share the same pattern and likely need the same guard as well (not verified though).. |
Member
|
I've thrown my buddy Claude at it. I'll either update this PR or open up a new one. 
|
Contributor
Author
|
Well then let Claude decide! 🥲 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #14946
The chromium render crash ("Aw, Snap") fires when all of these line up in the same click
display:noneto visible).When all three happen inside the one click, Chrome probably trips over its own editing/clipboard code and kills the tab.
In this commit we defer the reveal by one animation frame so the Bard editor is shown just after the click. That moves the work off the click, and the crash can't happen.