Conversation
Add typed wrappers for fetching account, trustline, and claimable balance entries. Reuse the account helper in LoadAccount and accept claimable balance IDs in strkey or hex form.
Contributor
There was a problem hiding this comment.
Pull request overview
Adds typed RPC helpers for common Stellar ledger-entry lookups.
Changes:
- Adds account, trustline, and claimable-balance helpers with validation and tests.
- Reuses account lookup logic in
LoadAccount. - Documents the new APIs and changelog entry.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
clients/rpcclient/main.go |
Refactors LoadAccount. |
clients/rpcclient/ledger_entries.go |
Implements ledger-entry helpers. |
clients/rpcclient/ledger_entries_test.go |
Adds helper tests. |
clients/rpcclient/doc.go |
Documents new methods. |
CHANGELOG.md |
Records the feature. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Accept all trustline-capable asset types in GetTrustline and reject native XLM before making an RPC request. Correct the liquidity-pool-share XDR discriminator and cover both pool-share representations with regression tests.
Author
|
Hi @leighmcculloch , friendly ping on this PR. I’ve synced the branch with the latest When you have a moment, could you please approve the workflows and review the proposed |
Reject incomplete liquidity pool change-trust assets and unsupported fees before deriving their trustline pool ID. Reuse the validation for GetLiquidityPoolID, add RPC and txnbuild regression coverage, and satisfy the repository shadow vet check.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
The full go test ./... run passed for non-database packages. The local support/db tests require PostgreSQL credentials unavailable in this environment.
Closes #5854