Conversation
Bump XDR_COMMIT to stellar-xdr 84cd9fa6 (PR stellar#318, unmerged) and enable the CAP_0087_ML_DSA feature gate, adding ContractCostTypes 86-94 for ML-DSA verifying-key/signature decoding and signature verification. Regeneration is mandatory rather than cosmetic: ContractCostTypeView.Value() matches an exhaustive whitelist of cost types, so it would reject 86-94 on any protocol-30 config-setting read. Unrelated upstream drift in the pinned range widens the contract-spec name fields to SC_SPEC_TYPE_NAME_LIMIT (1024) and retypes ScSpecEventV0.name from SCSymbol to a bounded string; no in-repo consumer references either. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Shaptic
reviewed
Sep 28, 2026
|
|
||
| const SC_SPEC_DOC_LIMIT = 1024; | ||
|
|
||
| const SC_SPEC_TYPE_NAME_LIMIT = 1024; |
Contributor
There was a problem hiding this comment.
I know it's not super related to this change but this seems unnecessarily large, no?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
XDR_COMMITto stellar-xdr@84cd9fa6c9ebe162e1d9dbbe89be9b6835498456(Protocol 30 (CAP-0087) stellar-xdr#318, unmerged) and setXDR_FEATURES ?= CAP_0087_ML_DSA.ContractCostType86-94 (ML-DSA decode + verify). Required, not cosmetic —ContractCostTypeView.Value()whitelists cost types exhaustively and would reject them.SC_SPEC_TYPE_NAME_LIMIT(1024) andScSpecEventV0.namebecomes a bounded string instead ofSCSymbol. No in-repo consumer.Deferred
XDR_COMMITpoints at an unmerged PR head; repoint it at the merged SHA in the productionizing pass.Upstream: stellar/stellar-xdr#318 · Downstream: stellar-horizon, stellar-rpc