Conversation
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
No unresolved review issues were identified.
Review effort: Lite
Findings: None
What changed in this PR
Adds regression coverage for decoding a pool-share ChangeTrust with issuer ordering that differs between key bytes and StrKey text.
Changes:
- Constructs the edge-case XDR operation.
- Verifies both pool assets decode correctly.
| File | Description |
|---|---|
test/unit/base/operations/change_trust.test.ts |
Adds the issuer-order decoding regression test. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds a test that decodes a pool-share
ChangeTrustwithOperation.fromXdrObject(). Its two assets share a code, and their issuers sort one way by key bytes and the other way as strkey text.Why
#1766 fixed
Asset.compare(), but its tests callcompare()directly. A user hit the bug through the decode path while indexing ledgers, so this covers that path. The test fails against the v17.2.0asset.ts. The v16 backport (#1768) adds the same test.