Disable publishing soroban-test crate - #1970
Merged
Merged
Conversation
leighmcculloch
marked this pull request as ready for review
March 17, 2025 23:47
leighmcculloch
enabled auto-merge (squash)
March 17, 2025 23:48
ifropc
approved these changes
Mar 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Prevent the soroban-test crate from being published to crates.io by setting publish=false in Cargo.toml.
Why
The soroban-test crate is intended for internal use only and should not be available on crates.io. While we can publish it, it introduces a lot of builds into the publish-dry-run workflow. It's unclear why it's being published, so unpublishing it for the time being seems okay. If someone brings it to our attention that publishing had some value, we can return to doing so as needed.
Close #1969