Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds weekly synchronization of Stellar Core LedgerCloseMeta fixtures and validates them through Horizon ingestion tests.
Changes:
- Adds scheduled/manual fixture synchronization and PR creation.
- Documents automated fixture ownership.
- Updates CI timeout rationale.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
.github/workflows/sync-core-lcm-fixtures.yml |
Synchronizes, tests, and proposes fixture updates. |
internal/ingest/core_lcm_test.go |
Warns against manual fixture edits. |
.github/workflows/go.yml |
Updates fixture-test runtime documentation. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
|
||
| - name: Open a pull request | ||
| if: steps.diff.outputs.changed == 'true' | ||
| uses: peter-evans/create-pull-request@v7 |
Contributor
Author
There was a problem hiding this comment.
bruh this can't possibly be that serious
| BASE_BRANCH: protocol-next | ||
| CORE_REF: ${{ github.event.inputs.core_ref || 'master' }} | ||
| FIXTURE_DIR: internal/ingest/testdata/test-lcms | ||
| CORE_LCM_DIR: test-lcm-next |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The new
sync-core-lcm-fixtures.ymlworkflow runs regularly and copies .xdr files fromstellar-core/test-lcm-currentinto the localinternal/ingest/testdata/test-lcmsso that theTestCoreLCMIngestionunit test always has the latestLedgerCloseMetafiles for its run.