Conversation
Repin go-stellar-sdk to the CAP-0084 XDR/strkey fork, bump MaxSupportedProtocolVersion to 30, add v30 test fixtures, and cover muxed-contract SAC destinations in ingestion tests.
XDR regenerated from stellar-xdr ee040cd6 with CAP_0084_MUXED_CONTRACT, matching stellar-core#5472.
Adds the muxed-contract SAC transfer/mint vectors and asserts destination_muxed_id survives ingestion.
P30 builds core #5472 from source (no -vnext artifact) and runs without a stellar-rpc image.
#5472 is merged and Jenkins has published its vnext deb and image, so the leg no longer builds the pre-merge head from source.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
MaxSupportedProtocolVersion30; go-stellar-sdk →sisuresh/go@73e446de(go-stellar-sdk#6015: XDRee040cd6+CAP_0084_MUXED_CONTRACT,W…strkey). v30 integration testdata are v29 copies.TestCoreLCMMuxedContractDestinationchecks that muxed-contracttransfer/mintkeepdestination_muxed_id.contract_creditedeffects carry only the baseC…contract; the muxed id is only in the op'sasset_balance_changes.-vnextartifact) with no stellar-rpc image, so RPC tests AMBER-skip.Upstream: stellar/go-stellar-sdk#6015, stellar/stellar-core#5472 · Downstream: stellar-rpc, quickstart