Fix Soroswap rewriting - #48
Merged
Merged
Conversation
Previously, the union pointers were shared across all rewrites causing an extra two LedgerKeys to get added to most Soroswap transactions. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
No unresolved review issues remain.
Review effort: Lite
Findings: None
What changed in this PR
Fixes Soroswap footprint rewriting by preventing shared ledger-key templates from being mutated across transactions.
Changes:
- Clone affected ledger-key union pointers before rewriting.
- Add sequential and concurrent regression tests.
| File | Description |
|---|---|
cmd/tx-load-test/soroswap/support_test.go |
Adds immutability and concurrency regression coverage. |
cmd/tx-load-test/soroswap/rewrite.go |
Prevents shared ledger-key data from being mutated. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Shaptic
approved these changes
Sep 29, 2026
Shaptic
left a comment
Shaptic
left a comment
There was a problem hiding this comment.
I don't really get what's happening here but I'll allow it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, the union pointers were shared across all rewrites causing an extra two LedgerKeys to get added to most Soroswap transactions (7 entries get written instead of the necessary 5).