perf-eval: report benchmark log scan errors - #1032
Open
vividvisit wants to merge 1 commit into
Open
vividvisit wants to merge 1 commit into
vividvisit wants to merge 1 commit into
Conversation
Signed-off-by: vividvisit <vividvisit@outlook.com>
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Scan errors after valid failure lines still return an unreliable partial package list instead of the suite marker.
Get a fresh assessment by requesting another Copilot review.
Review effort: Balanced
Findings: 1
Open (1)
What changed in this PR
Propagates benchmark output scanner errors so failed-package extraction problems are logged.
Changes:
- Return scanner errors from
parseFailedPkgs. - Add oversized-line error coverage.
| File | Description |
|---|---|
instantiate.go |
Propagates and logs scan errors. |
instantiate_test.go |
Tests oversized-line handling. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Propagate scanner errors while extracting failed packages from benchmark output.
An oversized or otherwise unreadable line previously produced an incomplete result with no diagnostic.
parseFailedPkgsnow returnsScanner.Err, andrunSuitelogs it before falling back to the suite-level failure marker.Why
[TODO: Why this change is being made. Include any context required to understand the why.]
Known limitations
[TODO or N/A]