Skip to content

fix(perf-eval): stop autolinking run numbers to issues in sticky comments - #991

Open
alorentiar wants to merge 1 commit into
stellar:mainfrom
alorentiar:fix/sticky-comment-issue-links
Open

alorentiar wants to merge 1 commit into
stellar:mainfrom
alorentiar:fix/sticky-comment-issue-links

Conversation

@alorentiar

Copy link
Copy Markdown

The perf-eval coordinator posts sticky comments on release PRs with the
run number rendered as "Performance Evaluation Test #N", which GitHub
autolinks to issues with matching numbers. Since the counter is usually
low on those PRs, issues like #1 and #2 end up collecting references
from unrelated eval comments.

As suggested in the issue, I inserted a zero-width space between the "#"
and the number in both places the text is rendered (current run header
and the history dropdowns). Displays the same, but doesn't link anymore.
Renderer tests updated to match, nothing else in the repo parses that
text.

Closes #988

Copilot AI balanced review requested due to automatic review settings September 9, 2026 04:09

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR prevents GitHub from autolinking the perf-eval coordinator’s sticky-comment run numbers (e.g. #1, #2) to unrelated issues by inserting a zero-width-space HTML entity between # and the run number wherever the label is rendered.

Changes:

  • Render run headers as Performance Evaluation Test #​N (current run header and folded history summaries) to avoid #N issue autolinks.
  • Update renderer tests to assert against the new escaped output.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
cmd/stellar-rpc/internal/integrationtest/infrastructure/perf-eval/coordinator-runner.go Inserts ​ into the run-number label in both the main header and history dropdown summaries.
cmd/stellar-rpc/internal/integrationtest/infrastructure/perf-eval/coordinator-runner_test.go Updates assertions to match the escaped run-number rendering.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

release eval harness: escape "#" in coordinator's sticky comments

2 participants