fix(perf-eval): stop autolinking run numbers to issues in sticky comments - #991
Open
alorentiar wants to merge 1 commit into
Open
alorentiar wants to merge 1 commit into
alorentiar wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Pull request overview
This PR prevents GitHub from autolinking the perf-eval coordinator’s sticky-comment run numbers (e.g. #1, #2) to unrelated issues by inserting a zero-width-space HTML entity between # and the run number wherever the label is rendered.
Changes:
- Render run headers as
Performance Evaluation Test #​N(current run header and folded history summaries) to avoid#Nissue autolinks. - Update renderer tests to assert against the new escaped output.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| cmd/stellar-rpc/internal/integrationtest/infrastructure/perf-eval/coordinator-runner.go | Inserts ​ into the run-number label in both the main header and history dropdown summaries. |
| cmd/stellar-rpc/internal/integrationtest/infrastructure/perf-eval/coordinator-runner_test.go | Updates assertions to match the escaped run-number rendering. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The perf-eval coordinator posts sticky comments on release PRs with the
run number rendered as "Performance Evaluation Test #N", which GitHub
autolinks to issues with matching numbers. Since the counter is usually
low on those PRs, issues like #1 and #2 end up collecting references
from unrelated eval comments.
As suggested in the issue, I inserted a zero-width space between the "#"
and the number in both places the text is rendered (current run header
and the history dropdowns). Displays the same, but doesn't link anymore.
Renderer tests updated to match, nothing else in the repo parses that
text.
Closes #988