fix(ruleset-migrator): handle non function objects returned by requir…#2957
Merged
tomek-tursa-sb merged 4 commits intoMay 20, 2026
Merged
Conversation
Sruthisreem
previously approved these changes
May 19, 2026
Agent-Logs-Url: https://github.com/stoplightio/spectral/sessions/e74baa1b-9b4f-493d-ac93-67a375ca79e6 Co-authored-by: tomek-tursa-sb <100731230+tomek-tursa-sb@users.noreply.github.com>
Contributor
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
…by-requireResolve
…by-requireResolve
Sruthisreem
approved these changes
May 20, 2026
barryadk
approved these changes
May 20, 2026
stoplight-bot
pushed a commit
that referenced
this pull request
May 21, 2026
## [1.12.1](https://github.com/stoplightio/spectral/compare/@stoplight/spectral-ruleset-migrator-1.12.0...@stoplight/spectral-ruleset-migrator-1.12.1) (2026-05-21) ### Bug Fixes * **deps:** post lodash update changes for semantic release ([#2942](#2942)) ([bf530dd](bf530dd)) * **ruleset-migrator:** handle non function objects returned by requireResolve ([#2957](#2957)) ([60c6c56](60c6c56)) * **rulesets:** exclude non-schema enum properties from duplicated-entry-in-enum rule ([#2934](#2934)) ([a7822fa](a7822fa)), closes [#2199](#2199) * **rulesets:** fix handling relative references in externalValue ([#2944](#2944)) ([6666ccc](6666ccc)), closes [#2819](#2819) ### Features * **core:** add error line number for yaml and json ruleset validation ([#2945](#2945)) ([04c1db3](04c1db3))
Collaborator
|
🎉 This PR is included in version 1.12.1 🎉 The release is available on Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Optional chaining (?.) only handles null/undefined, not non-function objects like {}.
Some webpack versions return {} instead of undefined for disabled browser modules.
Added typeof === 'function' check before calling requireResolve.