Skip to content

fix(ruleset-migrator): handle non function objects returned by requir…#2957

Merged
tomek-tursa-sb merged 4 commits into
developfrom
fix/handle-non-function-objects-returned-by-requireResolve
May 20, 2026
Merged

fix(ruleset-migrator): handle non function objects returned by requir…#2957
tomek-tursa-sb merged 4 commits into
developfrom
fix/handle-non-function-objects-returned-by-requireResolve

Conversation

@tomek-tursa-sb
Copy link
Copy Markdown
Contributor

Optional chaining (?.) only handles null/undefined, not non-function objects like {}.
Some webpack versions return {} instead of undefined for disabled browser modules.
Added typeof === 'function' check before calling requireResolve.

@tomek-tursa-sb tomek-tursa-sb requested a review from a team as a code owner May 19, 2026 13:35
Sruthisreem
Sruthisreem previously approved these changes May 19, 2026
Copy link
Copy Markdown
Contributor

Copilot AI commented May 19, 2026

Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • accounts.google.com
    • Triggering command: /proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=none --no-sandbox --disable-dev-shm-usage --use-angle=swiftshader-webgl --crashpad-handler-pid=5574 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/karma-29392040 --change-stack-guard-on-fork=enable --shared-files=v8_context_snapshot_data:100 --field-trial-handle=3,i,4867119315092165974,7941927172075283383,262144 --disable-features=PaintHolding --variations-seed-version --pseudonymization-salt-handle=7,i,12838888631051071003,6677789418495152824,4 --trace-process-track-uuid=3190708989122997041 (dns block)
    • Triggering command: /opt/google/chrome/chrome /usr/bin/google-chrome --user-data-dir=/tmp/karma-29392040 --enable-automation --no-default-browser-check --no-first-run --disable-default-apps --disable-popup-blocking --disable-translate --disable-REDACTED-timer-throttling --disable-renderer-REDACTEDing --disable-device-discovery-notifications --no-sandbox http://localhost:9876/?id=29392040 --headless --disable-gpu --disable-dev-shm-usage --remote-debugging-port=9222 (dns block)
    • Triggering command: /proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=none --no-sandbox --disable-dev-shm-usage --use-angle=swiftshader-webgl --crashpad-handler-pid=5875 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/karma-10163865 --change-stack-guard-on-fork=enable --shared-files=v8_context_snapshot_data:100 --field-trial-handle=3,i,876602120073165498,9777737329183491660,262144 --disable-features=PaintHolding --variations-seed-version --pseudonymization-salt-handle=7,i,2110184319739858770,3369748965421515670,4 --trace-process-track-uuid=3190708989122997041 (dns block)
  • android.clients.google.com
    • Triggering command: /proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=none --no-sandbox --disable-dev-shm-usage --use-angle=swiftshader-webgl --crashpad-handler-pid=5875 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/karma-10163865 --change-stack-guard-on-fork=enable --shared-files=v8_context_snapshot_data:100 --field-trial-handle=3,i,876602120073165498,9777737329183491660,262144 --disable-features=PaintHolding --variations-seed-version --pseudonymization-salt-handle=7,i,2110184319739858770,3369748965421515670,4 --trace-process-track-uuid=3190708989122997041 (dns block)
    • Triggering command: /opt/google/chrome/chrome /usr/bin/google-chrome --user-data-dir=/tmp/karma-10163865 --enable-automation --no-default-browser-check --no-first-run --disable-default-apps --disable-popup-blocking --disable-translate --disable-REDACTED-timer-throttling --disable-renderer-REDACTEDing --disable-device-discovery-notifications --no-sandbox http://localhost:9876/?id=10163865 --headless --disable-gpu --disable-dev-shm-usage --remote-debugging-port=9222 (dns block)
    • Triggering command: /proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=none --no-sandbox --disable-dev-shm-usage --use-angle=swiftshader-webgl --crashpad-handler-pid=6215 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/karma-66130750 --change-stack-guard-on-fork=enable --shared-files=v8_context_snapshot_data:100 --field-trial-handle=3,i,8886290222094843276,4869430190035012534,262144 --disable-features=PaintHolding --variations-seed-version --pseudonymization-salt-handle=7,i,15328548413448947709,124941038302144427,4 --trace-process-track-uuid=3190708989122997041 (dns block)
  • clients2.google.com
    • Triggering command: /proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=none --no-sandbox --disable-dev-shm-usage --use-angle=swiftshader-webgl --crashpad-handler-pid=5574 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/karma-29392040 --change-stack-guard-on-fork=enable --shared-files=v8_context_snapshot_data:100 --field-trial-handle=3,i,4867119315092165974,7941927172075283383,262144 --disable-features=PaintHolding --variations-seed-version --pseudonymization-salt-handle=7,i,12838888631051071003,6677789418495152824,4 --trace-process-track-uuid=3190708989122997041 (dns block)
    • Triggering command: /opt/google/chrome/chrome /usr/bin/google-chrome --user-data-dir=/tmp/karma-29392040 --enable-automation --no-default-browser-check --no-first-run --disable-default-apps --disable-popup-blocking --disable-translate --disable-REDACTED-timer-throttling --disable-renderer-REDACTEDing --disable-device-discovery-notifications --no-sandbox http://localhost:9876/?id=29392040 --headless --disable-gpu --disable-dev-shm-usage --remote-debugging-port=9222 (dns block)
    • Triggering command: /proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=none --no-sandbox --disable-dev-shm-usage --use-angle=swiftshader-webgl --crashpad-handler-pid=5875 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/karma-10163865 --change-stack-guard-on-fork=enable --shared-files=v8_context_snapshot_data:100 --field-trial-handle=3,i,876602120073165498,9777737329183491660,262144 --disable-features=PaintHolding --variations-seed-version --pseudonymization-salt-handle=7,i,2110184319739858770,3369748965421515670,4 --trace-process-track-uuid=3190708989122997041 (dns block)
  • clientservices.googleapis.com
    • Triggering command: /proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=none --no-sandbox --disable-dev-shm-usage --use-angle=swiftshader-webgl --crashpad-handler-pid=5574 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/karma-29392040 --change-stack-guard-on-fork=enable --shared-files=v8_context_snapshot_data:100 --field-trial-handle=3,i,4867119315092165974,7941927172075283383,262144 --disable-features=PaintHolding --variations-seed-version --pseudonymization-salt-handle=7,i,12838888631051071003,6677789418495152824,4 --trace-process-track-uuid=3190708989122997041 (dns block)
    • Triggering command: /opt/google/chrome/chrome /usr/bin/google-chrome --user-data-dir=/tmp/karma-29392040 --enable-automation --no-default-browser-check --no-first-run --disable-default-apps --disable-popup-blocking --disable-translate --disable-REDACTED-timer-throttling --disable-renderer-REDACTEDing --disable-device-discovery-notifications --no-sandbox http://localhost:9876/?id=29392040 --headless --disable-gpu --disable-dev-shm-usage --remote-debugging-port=9222 (dns block)
    • Triggering command: /proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=none --no-sandbox --disable-dev-shm-usage --use-angle=swiftshader-webgl --crashpad-handler-pid=5875 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/karma-10163865 --change-stack-guard-on-fork=enable --shared-files=v8_context_snapshot_data:100 --field-trial-handle=3,i,876602120073165498,9777737329183491660,262144 --disable-features=PaintHolding --variations-seed-version --pseudonymization-salt-handle=7,i,2110184319739858770,3369748965421515670,4 --trace-process-track-uuid=3190708989122997041 (dns block)
  • redirector.gvt1.com
    • Triggering command: /proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=none --no-sandbox --disable-dev-shm-usage --use-angle=swiftshader-webgl --crashpad-handler-pid=5574 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/karma-29392040 --change-stack-guard-on-fork=enable --shared-files=v8_context_snapshot_data:100 --field-trial-handle=3,i,4867119315092165974,7941927172075283383,262144 --disable-features=PaintHolding --variations-seed-version --pseudonymization-salt-handle=7,i,12838888631051071003,6677789418495152824,4 --trace-process-track-uuid=3190708989122997041 (dns block)
    • Triggering command: /opt/google/chrome/chrome /usr/bin/google-chrome --user-data-dir=/tmp/karma-29392040 --enable-automation --no-default-browser-check --no-first-run --disable-default-apps --disable-popup-blocking --disable-translate --disable-REDACTED-timer-throttling --disable-renderer-REDACTEDing --disable-device-discovery-notifications --no-sandbox http://localhost:9876/?id=29392040 --headless --disable-gpu --disable-dev-shm-usage --remote-debugging-port=9222 (dns block)
    • Triggering command: /proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=none --no-sandbox --disable-dev-shm-usage --use-angle=swiftshader-webgl --crashpad-handler-pid=5875 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/karma-10163865 --change-stack-guard-on-fork=enable --shared-files=v8_context_snapshot_data:100 --field-trial-handle=3,i,876602120073165498,9777737329183491660,262144 --disable-features=PaintHolding --variations-seed-version --pseudonymization-salt-handle=7,i,2110184319739858770,3369748965421515670,4 --trace-process-track-uuid=3190708989122997041 (dns block)
  • safebrowsingohttpgateway.googleapis.com
    • Triggering command: /proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=none --no-sandbox --disable-dev-shm-usage --use-angle=swiftshader-webgl --crashpad-handler-pid=5574 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/karma-29392040 --change-stack-guard-on-fork=enable --shared-files=v8_context_snapshot_data:100 --field-trial-handle=3,i,4867119315092165974,7941927172075283383,262144 --disable-features=PaintHolding --variations-seed-version --pseudonymization-salt-handle=7,i,12838888631051071003,6677789418495152824,4 --trace-process-track-uuid=3190708989122997041 (dns block)
    • Triggering command: /opt/google/chrome/chrome /usr/bin/google-chrome --user-data-dir=/tmp/karma-29392040 --enable-automation --no-default-browser-check --no-first-run --disable-default-apps --disable-popup-blocking --disable-translate --disable-REDACTED-timer-throttling --disable-renderer-REDACTEDing --disable-device-discovery-notifications --no-sandbox http://localhost:9876/?id=29392040 --headless --disable-gpu --disable-dev-shm-usage --remote-debugging-port=9222 (dns block)
    • Triggering command: /proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=none --no-sandbox --disable-dev-shm-usage --use-angle=swiftshader-webgl --crashpad-handler-pid=5875 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/karma-10163865 --change-stack-guard-on-fork=enable --shared-files=v8_context_snapshot_data:100 --field-trial-handle=3,i,876602120073165498,9777737329183491660,262144 --disable-features=PaintHolding --variations-seed-version --pseudonymization-salt-handle=7,i,2110184319739858770,3369748965421515670,4 --trace-process-track-uuid=3190708989122997041 (dns block)
  • www.google.com
    • Triggering command: /proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=none --no-sandbox --disable-dev-shm-usage --use-angle=swiftshader-webgl --crashpad-handler-pid=5574 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/karma-29392040 --change-stack-guard-on-fork=enable --shared-files=v8_context_snapshot_data:100 --field-trial-handle=3,i,4867119315092165974,7941927172075283383,262144 --disable-features=PaintHolding --variations-seed-version --pseudonymization-salt-handle=7,i,12838888631051071003,6677789418495152824,4 --trace-process-track-uuid=3190708989122997041 (dns block)
    • Triggering command: /opt/google/chrome/chrome /usr/bin/google-chrome --user-data-dir=/tmp/karma-29392040 --enable-automation --no-default-browser-check --no-first-run --disable-default-apps --disable-popup-blocking --disable-translate --disable-REDACTED-timer-throttling --disable-renderer-REDACTEDing --disable-device-discovery-notifications --no-sandbox http://localhost:9876/?id=29392040 --headless --disable-gpu --disable-dev-shm-usage --remote-debugging-port=9222 (dns block)
    • Triggering command: /proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=none --no-sandbox --disable-dev-shm-usage --use-angle=swiftshader-webgl --crashpad-handler-pid=5875 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/karma-10163865 --change-stack-guard-on-fork=enable --shared-files=v8_context_snapshot_data:100 --field-trial-handle=3,i,876602120073165498,9777737329183491660,262144 --disable-features=PaintHolding --variations-seed-version --pseudonymization-salt-handle=7,i,2110184319739858770,3369748965421515670,4 --trace-process-track-uuid=3190708989122997041 (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

@tomek-tursa-sb tomek-tursa-sb merged commit 60c6c56 into develop May 20, 2026
8 checks passed
@tomek-tursa-sb tomek-tursa-sb deleted the fix/handle-non-function-objects-returned-by-requireResolve branch May 20, 2026 08:31
stoplight-bot pushed a commit that referenced this pull request May 21, 2026
## [1.12.1](https://github.com/stoplightio/spectral/compare/@stoplight/spectral-ruleset-migrator-1.12.0...@stoplight/spectral-ruleset-migrator-1.12.1) (2026-05-21)

### Bug Fixes

* **deps:** post lodash update changes for semantic release ([#2942](#2942)) ([bf530dd](bf530dd))
* **ruleset-migrator:** handle non function objects returned by requireResolve ([#2957](#2957)) ([60c6c56](60c6c56))
* **rulesets:** exclude non-schema enum properties from duplicated-entry-in-enum rule ([#2934](#2934)) ([a7822fa](a7822fa)), closes [#2199](#2199)
* **rulesets:** fix handling relative references in externalValue ([#2944](#2944)) ([6666ccc](6666ccc)), closes [#2819](#2819)

### Features

* **core:** add error line number for yaml and json ruleset validation ([#2945](#2945)) ([04c1db3](04c1db3))
@stoplight-bot
Copy link
Copy Markdown
Collaborator

🎉 This PR is included in version 1.12.1 🎉

The release is available on @stoplight/spectral-ruleset-migrator-1.12.1

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants