You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Preserve normalized character height in PPTX - #1712
Preserves the normalized character-height setting on text runs through PPTX import and export. The regression test checks true, false, and absent values across two round trips, along with size, caps, and spacing.
Validation: cargo fmt --all and the focused PPTX round-trip test passed on Linux. Windows and macOS were not run.
Summary by CodeRabbit
New Features
PowerPoint text runs now preserve normalized character-height settings when imported and exported, including across repeated save-and-open cycles. The setting is retained whether enabled, disabled, or unspecified, along with related formatting such as font size, small caps, and spacing.
No actionable comments were generated in the recent review.
Walkthrough
The change adds normalize_height to run properties, inherits it when unset on a child, and maps it to DrawingML normalizeH during PPTX import and export. A round-trip test checks enabled, disabled, and absent values.
Changes: Normalize Character Height
Layer / File(s)
Summary
Run property and inheritance crates/model/src/text.rs
RunProps now includes optional normalize_height. Inheritance copies the parent value when the child value is unset.
PPTX mapping and round-trip validation crates/pptx/src/read/dml.rs, crates/pptx/src/write/dml.rs, crates/pptx/tests/it/roundtrip.rs
PPTX reading maps normalizeH to normalize_height, and writing maps the property back to normalizeH. The test checks enabled, disabled, and absent values across two round trips.
The change adds PPTX preservation of normalized character height. No merge-blocking issue was identified.
Pre-merge checks: 4 · 1
Failed checks: 1 warning
Check name
Status
Explanation
Resolution
Docstring Coverage
Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documenta…
Write docstrings for the functions missing them to satisfy the coverage threshold.
Passed checks: 4 passed
Check name
Status
Explanation
Description Check
Check skipped - CodeRabbit’s high-level summary is enabled.
Title check
The title clearly and concisely describes the main change: preserving normalized character height during PPTX import and export.
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage
Explanation
Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 2 functions across 4 files.
Resolution
Write docstrings for the functions missing them to satisfy the coverage threshold.
Finishing Touches
Generate unit tests (beta)
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Reviewing files that changed from the base of the PR and between 0c00f22 and d00ef08.
Files selected for processing: 4
crates/model/src/text.rs
crates/pptx/src/read/dml.rs
crates/pptx/src/write/dml.rs
crates/pptx/tests/it/roundtrip.rs
Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 2 remain after this review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preserves the normalized character-height setting on text runs through PPTX import and export. The regression test checks true, false, and absent values across two round trips, along with size, caps, and spacing.
Validation:
cargo fmt --alland the focused PPTX round-trip test passed on Linux. Windows and macOS were not run.Summary by CodeRabbit