Skip to content

Preserve normalized character height in PPTX - #1712

Merged
h-a-n-a-s-h-i merged 1 commit into
storytold:mainfrom
Harrison-Booth:dc-build-d719
Nov 3, 2026
Merged

h-a-n-a-s-h-i merged 1 commit into
storytold:mainfrom
Harrison-Booth:dc-build-d719

Conversation

@Harrison-Booth

@Harrison-Booth Harrison-Booth commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor

Preserves the normalized character-height setting on text runs through PPTX import and export. The regression test checks true, false, and absent values across two round trips, along with size, caps, and spacing.

Validation: cargo fmt --all and the focused PPTX round-trip test passed on Linux. Windows and macOS were not run.

Summary by CodeRabbit

  • New Features
    • PowerPoint text runs now preserve normalized character-height settings when imported and exported, including across repeated save-and-open cycles. The setting is retained whether enabled, disabled, or unspecified, along with related formatting such as font size, small caps, and spacing.

@coderabbitai

coderabbitai Bot commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review.

Walkthrough

The change adds normalize_height to run properties, inherits it when unset on a child, and maps it to DrawingML normalizeH during PPTX import and export. A round-trip test checks enabled, disabled, and absent values.

Changes: Normalize Character Height

Layer / File(s) Summary
Run property and inheritance
crates/model/src/text.rs
RunProps now includes optional normalize_height. Inheritance copies the parent value when the child value is unset.
PPTX mapping and round-trip validation
crates/pptx/src/read/dml.rs, crates/pptx/src/write/dml.rs, crates/pptx/tests/it/roundtrip.rs
PPTX reading maps normalizeH to normalize_height, and writing maps the property back to normalizeH. The test checks enabled, disabled, and absent values across two round trips.

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix

Suggested reviewers: echelon, aiongg

Merge Risk: Minimal · up to d00ef

The change adds PPTX preservation of normalized character height. No merge-blocking issue was identified.

Pre-merge checks: Passed 4 · Failed 1

Failed Failed checks: 1 warning

Check name Status Explanation Resolution
Docstring Coverage Warning Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documenta… Write docstrings for the functions missing them to satisfy the coverage threshold.
Passed Passed checks: 4 passed
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly and concisely describes the main change: preserving normalized character height during PPTX import and export.
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 2 functions across 4 files.

Resolution

Write docstrings for the functions missing them to satisfy the coverage threshold.

Finishing Touches
Generate unit tests (beta)
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

CodeRabbit Verify

  • Run CodeRabbit Verify to test the changes in this pull request.
Recent review info
Run configuration
Commits

Reviewing files that changed from the base of the PR and between 0c00f22 and d00ef08.

Files selected for processing: 4
  • crates/model/src/text.rs
  • crates/pptx/src/read/dml.rs
  • crates/pptx/src/write/dml.rs
  • crates/pptx/tests/it/roundtrip.rs

Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 2 remain after this review.

@h-a-n-a-s-h-i
h-a-n-a-s-h-i merged commit 5cb154c into storytold:main Nov 3, 2026
7 checks passed
@echelon

echelon commented Nov 3, 2026

Copy link
Copy Markdown
Member

Thanks @Harrison-Booth, landed on main as part of today's community batch.

If you haven't already, come join us on Discord: https://discord.gg/artcraft

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants