Repository navigation
Conversation
…ion, Recent menu - Dark mode draws a dark sheet; workbook colours are mapped by mirrored lightness (theme::adapt), following the System appearance. - Linux: undecorated window with our title bar, window controls, rounded corners, edge resizing and one solid backdrop under all panels; 4x MSAA. - Menus, popups and dialogs are frosted glass over the content beneath (glass.rs). - Eased, zero-bounce motion: selection glide, sliding tab underlines, hover fades. - Recent workbooks menu in the title bar and on the Start screen, saved as it changes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Thank you — there's a lot of polish here. Changing the default look for everyone (dark palette, dark canvas that recolours workbook colours, frameless transparent window on Linux, frosted glass, motion) is a product decision we're holding for the maintainers. Independently of that: the glass pass re-adds every background shape 17 times per open popup per frame, which is expensive on large sheets, and the branch conflicts in 9 files. Would you split it? The Recent menu (with preferences saved without a global static Mutex) and the resize handles could land on their own; the theme/canvas/glass/chrome changes can follow once the direction is agreed. If you haven't already, please come join us on Discord: https://discord.gg/artcraft — happy to talk any of this through there. |
|
Hi @dragosol, thanks for this PR. GitHub currently reports a merge conflict between this branch and |
…lay theme Dark leaves the cells alone Reverses H3 at the user's request: the shape upstream maintainers are likely to accept, since changing the default look for everyone is their decision (PR storytold#177). Restores the code and docs of 41750be^; Dark sheet and Animations share one row in the View tab so the group fits the card (N1). Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01YFa1DitgUd9yV4AvGTW7AX
Summary
Desktop polish from running GridCraft daily on Fedora 44 / GNOME 50 (Wayland, 4K). Everything lives in
crates/ui-eguiplus window options inapps/gridcraft; colours still come fromtheme::Tokens, and nothing changes for the engine, CLI, MCP or control channel. It's one commit, but the pieces are independent, so feel free to take only some of them. A list of what's here:A dark mode that's actually dark
theme::adapt. In dark mode it mirrors HSL lightness and keeps hue and saturation, so black text reads light, white fills go near-black, and a cell's text keeps its contrast against its fill. This also covers charts, data bars, number-format colours, note and validation popups, filter buttons and the in-cell editor. Light mode is untouched.set_canvas_darkruns each frame from the effective theme, so it follows the new System appearance (Add System appearance alongside Light and Dark themes #96).Linux window chrome
ViewportCommand::BeginResize.Frosted glass for floating surfaces (
glass.rs)Motion
theme::glide,glide_rect,fade,hover_fill).Recent workbooks
ui.jsonis written as soon as the list changes. Previously the list was saved only on a clean exit.Smaller theme touches
Not included, because other PRs already cover these: listing and rendering installed system fonts (#9), separate native windows per workbook (#171 and #27), and non-Latin font fallbacks (#38, #103, #147).
Testing
cargo xtask cipasses locally (fmt, clippy-D warnings, tests, assets, layers, wasm).ui.screenshot. Window corners are transparent with no gaps inside the window, and the frosted popups and dialogs were checked over charts.snapshotexample in both light and dark.cfg(target_os = "linux"), and the theme and motion changes are platform-neutral.🤖 Generated with Claude Code