Repository navigation
Snapshot: catalog installed fonts before rendering - #2275
Conversation
The offscreen snapshot never started the background font scan the app runs from its first frame, so a workbook's installed fonts (Helvetica Neue, say) were drawn in the Calibri substitute. Catalog them up front and run a few more frames so they bind, as in the app. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to
|
|
Landed on main. Thank you for this contribution, @pick2510! Good to see you on the Discord too if you're not there yet: https://discord.gg/artcraft |
Summary
snapshotexample never started the font scan that the app runs from its first frame. A workbook's installed fonts (e.g. Helvetica Neue) were therefore drawn in the Calibri substitute.fonts::catalog()before building the session, and runs 14 frames instead of 8 so the fonts bind as they do in the app.Found while comparing snapshots with Excel: a Helvetica Neue workbook rendered in Carlito.
Test plan
cargo xtask ci: fmt, clippy, assets, layers, wasm, parity and keytips pass. The one test failure isheader_autofit::table_filter_autofit_…, which depends on installed fonts and is fixed by test: header AutoFit check measures the text as AutoFit did #2273.Example-only change, so there is no unit test; it changes no library code.
🤖 Generated with Claude Code
Summary by CodeRabbit