Repository navigation
Conversation
|
No actionable comments were generated in the recent review.
|
| Layer / File(s) | Summary |
|---|---|
Add Arabic face to font policy and tests crates/ui-egui/src/craft_fonts_policy.rs, crates/ui-egui/src/theme/tests.rs, crates/ui-egui/tests/it/symbol_glyphs.rs |
The required-face list and web allowlist include Noto Sans Arabic Regular with the Arab script tag. The policy and integration tests expect the added face. A comment clarifies the native-build permitted-face set. |
Priority:
Estimated code review effort: 2 (Simple) | ~8 minutes
Change: Feature
Possibly related issues
- UI text in non-Latin scripts: fallback in egui 0.37, bidi upstream craft-libs#17: The change adds an Arabic fallback face, matching the issue’s objective of reducing missing non-Latin glyphs in egui UI text.
- Proposal: one coverage-driven system-font fallback instead of a hand-written function per script pdfcraft#2796: The change adds one embedded Arabic face, addressing part of the issue’s broader font-fallback objective.
- Language support across the craft apps: fonts, text, input and locale craft-libs#198: The change adds an Arabic web font, matching part of the issue’s shared web-font objective.
- Release: re-pin craft-fonts to a commit with both the Latin manifest and Noto Sans Thai figcraft#1214: The change adds an Arabic web font through the embedded-font mechanism, but does not add Thai coverage.
- Right-to-left languages: what the interface needs before Arabic, Hebrew or Persian can ship lightcraft#1395: The change adds Arabic font coverage, but does not implement bidi or mirroring behavior.
Suggested reviewers: skylartaylor, aiongg
Merge Risk: 
Minimal · up to 74330
-
No actionable merge-blocking risk is evident; the Arabic font policy change is internally consistent.
Pre-merge checks: 
5
-
Full details: Docstring Coverage
-
Explanation
Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 3 functions across 3 files.
-
Finishing Touches
-
🧪 Generate unit tests (beta)
-
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Comment @coderabbitai help to get the list of available commands.
|
Review checks on head 74330c0:
Thai could land first. Arabic then needs the Thai and Arabic entries combined in |
FredApps
left a comment
There was a problem hiding this comment.
ReviewerA — source-read COMMENT (not an approval)
I read the whole diff: Noto Sans Arabic (Regular, script Arab) is added to REQUIRED_FACES and WEB_ALLOWED, with the policy test and symbol-glyph test updated. craft-fonts' manifest does list that face with script Arab, so the required-face check can be satisfied. The comment states about 845 KB added to the wasm bundle; please confirm the web size gate still passes (and its budget), and that the fonts pin used by the build includes that face. Not run; no exact-head CI result.
I ran nothing and have no exact-head CI result for this PR, so this is not an approval.
Status: waiting_author.
|
Thanks for the review. I checked both points locally on 74330c0. Fonts pin: ci.yml and release.yml pin craft-fonts-ref to b076417b. Its fonts/manifest.txt lists "Noto Sans Arabic | Regular | ... | Arab", and the file's sha256 matches the manifest (63111b5b...), 844,676 bytes. The web build also passes with CRAFT_FONTS_REQUIRED=1, which fails when a listed face is missing. Web size: I couldn't find an automated size gate or a budget number in xtask or in craft-common-actions; docs/egui-037-local-followups.md:166 says the size is not measured yet. So I measured it with
The raw delta is about the size of the font file, so nothing else changed. If you'd like a budget enforced, I'm happy to add a check with a number you pick. One note: release.yml doesn't pass |
Summary by CodeRabbit