Skip to content

Grant network access so update checks can reach GitHub - #2841

Merged
dylanmtaylor merged 1 commit into
mainfrom
fix/flatpak-network-share
Oct 28, 2026
Merged

dylanmtaylor merged 1 commit into
mainfrom
fix/flatpak-network-share

Conversation

@dylanmtaylor

Copy link
Copy Markdown
Member

The Flatpak sandbox had no network permission, so the update check failed with "couldn't reach GitHub (Temporary failure in name resolution)". Both manifests now include --share=network in finish-args, and the comment that said network was deliberately not granted is updated to match. The change is limited to finish-args and that comment, and the two manifests stay identical in finish-args.

Per maintainer decision.

@dylanmtaylor
dylanmtaylor merged commit 70327cd into main Oct 28, 2026
5 checks passed
@dylanmtaylor
dylanmtaylor deleted the fix/flatpak-network-share branch October 28, 2026 17:07
@coderabbitai

coderabbitai Bot commented Oct 28, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Caution

Review failed

The pull request is closed.

Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@sonarqubecloud

sonarqubecloud Bot commented Oct 28, 2026 •

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues
0 New dependency risks

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant