Skip to content

UI: favorite themes and appearance shortcuts - #299

Closed
luniiya wants to merge 1 commit into
storytold:mainfrom
luniiya:feat/theme-favorites
Closed

luniiya wants to merge 1 commit into
storytold:mainfrom
luniiya:feat/theme-favorites

Conversation

@luniiya

@luniiya luniiya commented Oct 11, 2026

Copy link
Copy Markdown

Port of storytold/photocraft#2445 (theme favorites), now merged there.

  • Each theme in the appearance picker gets a star (shown on hover, filled when starred).
  • Favorites are saved with the preferences and survive a restart.
  • Right-click the appearance control for a shortcut menu: Appearance Settings… plus the starred themes, so switching between favorites takes one click.
  • New strings are translated in every catalog the i18n tests require.

GridCraft's shortcut menu sits on the View tab's display theme combo box. egui stores the combo popup under the same id a plain context_menu uses, so the right-click menu gets its own id. Without that, the combo box would never open (the existing system_theme UI test caught it).

Tests: unit tests for the favorites list and its persistence, and a UI test that stars a theme and picks it from the right-click menu.

cargo xtask ci: fmt, clippy and test pass, plus assets and layers. I couldn't run the wasm step on my machine because it lacks the wasm32-unknown-unknown std.

Port of storytold/photocraft#2445. Each theme in the appearance picker gets a
star; starred themes are saved with the preferences and listed in a
right-click menu on the appearance control, next to Appearance Settings, so
switching between favorites takes one click.

The shortcut menu sits on the display theme combo box, whose popup egui
keeps under the same id a plain context menu uses, so the menu gets its
own id; otherwise the combo box could no longer open.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant