Repository navigation
Conversation
Port of storytold/photocraft#2445. Each theme in the appearance picker gets a star; starred themes are saved with the preferences and listed in a right-click menu on the appearance control, next to Appearance Settings, so switching between favorites takes one click. The shortcut menu sits on the display theme combo box, whose popup egui keeps under the same id a plain context menu uses, so the menu gets its own id; otherwise the combo box could no longer open.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Port of storytold/photocraft#2445 (theme favorites), now merged there.
GridCraft's shortcut menu sits on the View tab's display theme combo box. egui stores the combo popup under the same id a plain
context_menuuses, so the right-click menu gets its own id. Without that, the combo box would never open (the existingsystem_themeUI test caught it).Tests: unit tests for the favorites list and its persistence, and a UI test that stars a theme and picks it from the right-click menu.
cargo xtask ci: fmt, clippy and test pass, plus assets and layers. I couldn't run the wasm step on my machine because it lacks thewasm32-unknown-unknownstd.