Skip to content

contributors: set names for vangel76 - #3331

Merged
FredApps merged 1 commit into
storytold:mainfrom
vangel76:contributors-vangel76-names
Nov 7, 2026
Merged

FredApps merged 1 commit into
storytold:mainfrom
vangel76:contributors-vangel76-names

Conversation

@vangel76

@vangel76 vangel76 commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

Updates the contributors entry for the PR author (vangel76) in contributors/people.toml: real name, display name, and GitHub name sync off. The entry is set by the author themselves.

contributors.json is not touched; it is generated.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Updates
    • The contributor listing continues to display the name vangel76. That displayed name is no longer automatically synchronized with the associated GitHub name, so it remains unchanged if the GitHub name changes. No other contributor display-name changes are included in this update.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Nov 4, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review.

Walkthrough

The vangel76 entry in contributors/people.toml now disables GitHub name synchronization. Its display name remains unchanged.

Changes: Contributor record update

Layer / File(s) Summary
Update contributor name synchronization
contributors/people.toml
The vangel76 entry sets sync_github_name to false. Its display name remains unchanged.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Change: Other

Possibly related issues

  • The PR updates the contributor record but does not regenerate contributors.json, so it does not implement the full fix described in storytold/gridcraft issue 1810.

Suggested reviewers: aiongg, echelon

Merge Risk: Minimal · up to b3a70

No merge-blocking issue was identified in this contributor metadata update.

Pre-merge checks: Passed 5
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly identifies the contributor update for vangel76. It matches the main change, including the name and GitHub name synchronization settings.
Docstring Coverage Passed No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

Finishing Touches
Generate unit tests (beta)
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share
Recent review info
Run configuration
Commits

Reviewing files that changed from the base of the PR and between 014f030 and b3a709f.

Files selected for processing: 1
  • contributors/people.toml

Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 6 remain after this review.

@FredApps FredApps left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed current head b3a709f314ef7203959f23a121836868342451aa. No findings. The complete diff changes only the PR author's own people.vangel76 entry: an explicit display name and GitHub-name sync disabled. I parsed the complete TOML successfully and checked this against the contributor-credit rules; generated contributors.json and other people's entries are untouched.

Verified the current-head gate: cargo xtask ci passed, including 3,376 tests (1 skipped). No local build was run for this metadata-only review. Approved.

@FredApps
FredApps merged commit 66bb6ae into storytold:main Nov 7, 2026
6 checks passed
@FredApps

FredApps commented Nov 7, 2026

Copy link
Copy Markdown
Contributor

Merged reviewed head b3a709f314ef7203959f23a121836868342451aa into main as 66bb6ae239395379427701bfe9fbd8a3ca1976ac after rechecking the approval, current checks, and mergeability. The applicable CI gate was green before merging.

Review: #3331 (review)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants