Repository navigation
Keyboard: Shift+Space and Ctrl+Space select without starting an edit (#338) - #395
Merged
h-a-n-a-s-h-i merged 1 commit intoOct 11, 2026
Merged
Conversation
…torytold#338) Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Member
|
Merged — thank you for the contribution! (I resolved a small grid.rs conflict so the Alt+F8 Macros shortcut from #19 stays.) If you haven't already, come join us on the ArtCraft Discord: https://discord.gg/artcraft |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #338
Root cause
Text(" "); the grid treated it as typing and calledbegin_edit(" ").m.commandonly, which on macOS is Cmd (Spotlight). Excel for Mac uses Control+Space.Changes
grid.rs: Text events are ignored in the same frame as a pressed key with Ctrl/Cmd (no Alt, so AltGr text still works) or Shift+Space.keymap.rs: Space bindings moved intolookup: Shift+Space = row; Ctrl+Space (Windows/Linux) and Control+Space (Mac) = column; Cmd+Space is left unbound.Tests / commands
keyboard_shortcuts: Key(Space)+Text(" ") with Shift selects the row, with Ctrl selects the column, neither starts an edit; plain typing still edits; per-platformlookuptest (incl. Cmd+Space unbound).cargo test -p gridcraft-ui-egui --test keyboard_shortcuts,cargo clippy -p gridcraft-ui-egui --lib --test keyboard_shortcuts -- -D warnings,cargo fmt -p gridcraft-ui-egui -- --check.Not done
Unverified
🤖 Generated with Claude Code